Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDVA-38346 fixes for the admin grids #91

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

alucardatem
Copy link

Admin order grids fixes

Description

Issue with filtering based on created_at / updated_at after implementing custom type joins

Fixed Issues (if relevant)

Created_at / updated_at filtering issue on grids after doing any type of custom joins

fix on the patch outcome so that it permits alterations of the sales order grid without creating errors on any types of joins with sales_order or any other type of table that has create_at and updated_at
@alucardatem alucardatem reopened this Nov 11, 2022
@alucardatem alucardatem changed the title Admin order grids fixes MDVA-38346 fixes for the admin grids Nov 11, 2022
@alucardatem
Copy link
Author

will this be looked into ?

@BaDos
Copy link
Contributor

BaDos commented Nov 16, 2022

@viktym could you check this PR?

@alucardatem
Copy link
Author

@viktym could you check this PR?

thank you for this.
in order to replicate - having any kind of grid modification that joins on tables that have created_at and then filtering by date ends up with the error.

[2022-11-10 14:31:05] main.CRITICAL: SQLSTATE[23000]: Integrity constraint violation: 1052 Column 'created_at' in where clause is ambiguous, query was: SELECT COUNT(*) FROM sales_order_gridASmain_tableLEFT JOINbraintree_transaction_detailsON braintree_transaction_details.order_id = main_table.entity_id RIGHT JOINsales_order ON main_table.entity_id = sales_order.entity_id WHERE (((created_at >= '2022-11-01 00:00:00'))) AND (((created_at <= '2022-11-04 23:59:59')))

even when trying to add an overwrite on initSelect

@alucardatem
Copy link
Author

This is causing issues on higher versions of magento when applying the patch as it is still relevant and date search is not working.

If my PR is not good then please by all means correct it and push proper version of it ?

@gbobts
Copy link

gbobts commented May 29, 2024

@BaDos @viktym is this repo still actively maintained ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants