This repository has been archived by the owner on Jan 25, 2024. It is now read-only.
Provide stop and status Commands
#3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A fairly simple command that will stop a running service. Sometimes you can encounter difficulty when trying to stop a service gracefully, but I decided to only attempt to stop the service once and leave any retries to the service infrastructure.
The command provides both a summary and a detailed view of installed services. It checks to see whether the service process is still running, because it's possible the process could have died since the last time we checked. The data and log directories were added to the `InstalledNode` struct so that we could keep track of these and display them in the detailed status view since it seems like useful information to have.
With `stop` and `status` commands, we can have a more elaborate test that exercises all the important functionality in the node manager. Using the status reported by the application allows us to make the test cross platform.
jacderida
force-pushed
the
stop-and-status
branch
from
edcec75
to
29b2fae
Compare
b-zee
approved these changes
Nov 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
82bc33d feat: provide
stopcommandA fairly simple command that will stop a running service.
Sometimes you can encounter difficulty when trying to stop a service gracefully, but I decided to
only attempt to stop the service once and leave any retries to the service infrastructure.
55d1ad9 feat: provide
statuscommandThe command provides both a summary and a detailed view of installed services.
It checks to see whether the service process is still running, because it's possible the process
could have died since the last time we checked.
The data and log directories were added to the
InstalledNodestruct so that we could keep track ofthese and display them in the detailed status view since it seems like useful information to have.
edcec75 test: extend the e2e test for new commands
With
stopandstatuscommands, we can have a more elaborate test that exercises all theimportant functionality in the node manager.
Using the status reported by the application allows us to make the test cross platform.