Update upload data flow #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuef
changed the title
jacderida
approved these changes
Sep 28, 2023
| // TODO: | ||
| // Ensure gen node has `safe` client | ||
| // get the test data from somewhere | ||
| let output = testnet_deploy.ssh_client.run_script( |
There was a problem hiding this comment.
I think it would be nicer if the code for this went in the upload_test_data function that was in the TestDataClient and replaced what is in there.
That client would need to have its definition extended to accept the SshClientInterface, but that should be OK.
| // Finally, parse the output to get the uploaded files | ||
|
|
||
|
|
||
| // println!("Uploaded files:"); |
There was a problem hiding this comment.
Can we remove this commented out stuff?
| // println!("Uploaded files:"); | ||
| // for (path, address) in uploaded_files.iter() { | ||
| // println!("{path}: {address}"); | ||
| // } | ||
| inventory.add_uploaded_files(uploaded_files.clone()); |
There was a problem hiding this comment.
Does this work any more now that it's a remote script? Is it returning back the path and address?
| // It takes a PathBuf as an argument which represents the inventory path. | ||
| // It returns a Result containing a vector of tuples. Each tuple contains a string representing the name and the ansible host. | ||
| fn inventory_list(&self, inventory_path: PathBuf) -> Result<Vec<(String, IpAddr)>> { | ||
| // Run the external command and store the output. |
There was a problem hiding this comment.
To be honest, I find some of these comments are just stating what the code says fine on its own, but not a big deal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.