This repository has been archived by the owner on Mar 13, 2022. It is now read-only.
Avoid deadlock with subprocess #128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the pep8 violation |
Heed Python's subprocess module documentation warnings about deadlock when using PIPE for a Popen object's stderr with Popen.wait() and Popen.stderr.read() and use Popen.communicate() instead. Fixes major#126.
coreywright
force-pushed
the
avoid_deadlock_with_subprocess
branch
from
3af09c4 to
67146a4
Compare
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 6 6
Lines 392 391 -1
Branches 82 82
=====================================
- Hits 392 391 -1
Continue to review full report at Codecov.
|
|
force pushed up a new commit to clarify where these |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heed Python's subprocess module documentation warnings about deadlock
when using PIPE for a Popen object's stderr with Popen.wait() and
Popen.stderr.read() and use Popen.communicate() instead.
Fixes #126.