Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added step to dog for LR != CR support #200

Open
wants to merge 1 commit into
base: liq-2.0
Choose a base branch
from

Conversation

hexonaut
Copy link
Contributor

@hexonaut hexonaut commented Feb 3, 2021

Not super sold on the name step, but basically this small addition will enable to set the liquidation ratio to be less than the vat collateralization ratio. If this has to be pushed after the initial LIQ-2.0 launch so be it, but I figured it was worth discussing to maybe sneak it in while we are still finalizing deployment.

The step multiplication is performed to the art instead of the art * rate so as to not to hit the overflow limit.

@godsflaw
Copy link
Contributor

godsflaw commented Mar 3, 2021

We think this is a good change, but it wasn't discussed in MIP45 and is a heavier change since the code freeze. There is a change to have an ilk based sin queue in #147 that will require us to update the vow and the dog in the future. We were thinking we should queue this up for that release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants