Merge pull request #815 from ymleyva12/pullrequest-author-login

Bug fix "Cannot read properties of null (reading 'login')" in mips de…
makerdao · Apr 26, 2024 · 7e70202 · 7e70202
2 parents 67d6096 + 9435fe0
commit 7e70202
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/.../src/app/modules/mips/components/pull-request-history/pull-request-history.component.html b/.../src/app/modules/mips/components/pull-request-history/pull-request-history.component.html
@@ -7,7 +7,7 @@
     <span class="label">{{pullrequest.close}} {{'Closed'| translate}}</span>
   </div>
   <hr>
-  <div *ngFor="let item of pullrequest.items.slice(0, 3)">
+  <div *ngFor="let item of getFilteredItems()">
     <span class="row">
       <div class="info">{{item.title}} </div>
       <a href="{{item.url}}" target="_blank"><img class="open" src="../../../../../assets/images/open.svg" /></a>

diff --git a/...nd/src/app/modules/mips/components/pull-request-history/pull-request-history.component.ts b/...nd/src/app/modules/mips/components/pull-request-history/pull-request-history.component.ts
@@ -37,4 +37,8 @@ export class PullRequestHistoryComponent implements OnInit {
     window.location.href = this.pullrequest.url;
   }
 
+  getFilteredItems(): string {
+    return this.pullrequest.items.filter(item => item.author != null).slice(0, 3);
+  }
+
 }