Skip to content

Commit

Permalink
improve payments structure, mention tests
Browse files Browse the repository at this point in the history
  • Loading branch information
SidestreamColdMelon committed Jan 8, 2024
1 parent b07f8ec commit c3832e1
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion spell/spell-reviewer-mainnet-checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,7 @@
* IF `MKR` transfers are present
* [ ] Recipient address in the instruction is in the checksummed format
* [ ] Recipient address matches Exec Doc
* [ ] Recipient address variable name match one found in `addresses_wallets.sol`
* [ ] Transfer amount matches Exec Doc
* [ ] Transfer amount is specified with (at least) 2 decimals using `ether` keyword
* [ ] IF `ether` keyword is used, comment is present on the same line `// Note: ether is a keyword helper, only MKR is transferred here`
Expand All @@ -228,6 +229,7 @@
* IF `DAI` surplus buffer transfers are present
* [ ] Recipient address in the instruction is in the checksummed format
* [ ] Recipient address matches Exec Doc
* [ ] Recipient address variable name match one found in `addresses_wallets.sol`
* [ ] Transfer amount matches Exec Doc
* [ ] The transfers are tested via `testDAIPayments` test
* [ ] Sum of all DAI transfers tested in `testDAIPayments` matches number in the Exec Doc
Expand All @@ -236,6 +238,7 @@
* [ ] `restrict` is used for each stream unless otherwise explicitly stated in the Exec Doc
* [ ] `usr` (Vest recipient address) matches Exec Doc
* [ ] `usr` address in the instruction is in the checksummed format
* [ ] `usr` address variable name match one found in `addresses_wallets.sol`
* [ ] `tot` (Total stream amount) matches Exec Doc
* [ ] IF `ether` keyword is used, comment is present on the same line `// Note: ether is a keyword helper, only MKR is transferred here`
* [ ] IF vest amount is expressed in 'per year' or similar in the Exec Doc, account for leap days
Expand All @@ -259,11 +262,12 @@
* IF MKR stream ([DssVestTransferrable](https://github.com/makerdao/dss-vest/blob/master/src/DssVest.sol#L463)) is present
* [ ] Vest contract's MKR allowance increased by the cumulative `total` (the sum of all `tot` values)
* [ ] Ensure allowance increase follows archive patterns
* [ ] Tested via `testVestDAI` or `testVestMKR`
* IF `MKR` or `DAI` vest termination (`Yank`) is present
* [ ] Yanked stream ID matches Exec Doc
* [ ] `MCD_VEST_MKR_TREASURY` chainlog address is used for MKR stream `yank`
* [ ] `MCD_VEST_DAI` chainlog address is used for DAI stream `yank`
* [ ] Ensure Recipient Addresses match `addresses_wallets.sol`
* [ ] Tested via `testYankDAI` or `testYankMKR`
* IF SubDAO-related content is present
* IF SubDAO provides SubProxy spell address
* [ ] SubDAO spell address matches Exec Doc
Expand Down

0 comments on commit c3832e1

Please sign in to comment.