Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend checklist with UTC checks #16

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Extend checklist with UTC checks #16

merged 1 commit into from
Dec 12, 2023

Conversation

SidestreamColdMelon
Copy link
Contributor

Based on the inconsistency spotted in the recent spell, this is a proposal to enhance mainnet reviewer checklist by including explicit UTC timezone check.

@SidestreamColdMelon SidestreamColdMelon mentioned this pull request Nov 30, 2023
Merged
14 tasks
amusingaxl
amusingaxl approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@amusingaxl amusingaxl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Explicit is better than implicit.

@SidestreamColdMelon SidestreamColdMelon merged commit 8e07534 into master Dec 12, 2023
@SidestreamColdMelon SidestreamColdMelon deleted the improvement-to-ensure-utc branch December 12, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amusingaxl amusingaxl amusingaxl approved these changes

@0xdecr1pto 0xdecr1pto 0xdecr1pto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SidestreamColdMelon @amusingaxl @0xdecr1pto