Merge pull request #139 from psivesely/fix-trivial-sis-cases

Correct trivial SIS cases in sis_lattice.py
malb · Jan 27, 2025 · 6b25d9d · 6b25d9d
2 parents 374f073 + 5879aa1
commit 6b25d9d
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/estimator/sis_lattice.py b/estimator/sis_lattice.py
@@ -55,8 +55,8 @@ def cost_euclidean(
         **kwds,
     ):
         # Check for triviality
-        if params.length_bound >= sqrt(params.m) * (params.q / 2):
-            raise ValueError("SIS trivially easy. Please set norm bound < √{m}⋅q/2.")
+        if params.length_bound >= (params.q-1) / 2:
+            raise ValueError("SIS trivially easy. Please set norm bound < (q-1)/2.")
 
         if d is None:
             d = min(floor(SISLattice._opt_sis_d(params)), params.m)
@@ -104,8 +104,8 @@ def cost_infinity(
             it merely reports costs.
 
         """
-        if params.length_bound >= params.q:
-            raise ValueError("SIS trivially easy. Please set norm bound < q.")
+        if params.length_bound >= (params.q-1)/2:
+            raise ValueError("SIS trivially easy. Please set norm bound < (q-1)/2.")
 
         if d is None:
             d = params.m