-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build and test the project with sanitizers enabled #3754
Comments
@jjerphan I actually think this change is super beneficial in the long run. So, if someone wants to work on this, it would be great. |
Yes, I agree this would be beneficial and I am in favor of it. Feel free to work on it if you want to. For now, we are focused on addressing issues after the 2.0 release. |
Note that this was already the intent for a while but the blocking issue is that sanitizers will either not work or report false-positives because of dependencies not being built with sanitizers or with debug info. Our dependencies come from conda packages which are exclusively "release" kind of builds so that doesnt work. What would work is to have a separate set of builds not using conda packages, with dependencies built from sources with sanitizers enabled, therefore probably vcpkg-based. That can also lead to an invisible divergence between how conda dependencies are built and vcpkgs. So the other solution is to have sanitizer builds of conda packages (or maybe just debug would work? not sure on windows). Both solutions are not really trivial. |
We have options to enable sanitizers in
libmamba
.It would be nice:
libmamba
, but for the whole project) - there is a C++ code inmicromamba
andlibmambapy
as well, so we might have some bugs there as wellJust having these options unfortunately doesn't prevent us from bugs and they are much more difficult to fix over time.
The text was updated successfully, but these errors were encountered: