maint: Add missing thread and undefined sanitizers CMake options #3753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjerphan
approved these changes
Jan 16, 2025
libmamba/CMakeLists.txt
Outdated
| @@ -91,6 +90,7 @@ if(ENABLE_ASAN) | |||
| add_link_options(-fno-omit-frame-pointer -fsanitize=address) | |||
| endif() | |||
|
|
|||
| option(ENABLE_TSAN "Enable Thread-Sanitizer (currently only supported on GCC and Clang)" OFF) | |||
There was a problem hiding this comment.
Can you group all the options together bellow this comment:
# Build options
# =============?
There was a problem hiding this comment.
I prefer not to - if someone want to work on #3754, it would be easy to remove the chunk of code from here and put it to cmake/Sanitizers.cmake.
This way it will start working for the whole repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.