Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: Add missing thread and undefined sanitizers CMake options #3753

Merged
merged 2 commits into from
Jan 16, 2025
Merged

maint: Add missing thread and undefined sanitizers CMake options #3753

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9275b9
maint: Add missing thread and undefined sanitizers CMake options
mathbunnyru Jan 16, 2025
e692aca
Better naming
mathbunnyru Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion libmamba/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ if(WIN32)
endif()

option(ENABLE_ASAN "Enable Address-Sanitizer (currently only supported on GCC and Clang)" OFF)

if(ENABLE_ASAN)
message(
WARNING
Expand All @@ -91,6 +90,7 @@ if(ENABLE_ASAN)
add_link_options(-fno-omit-frame-pointer -fsanitize=address)
endif()

option(ENABLE_TSAN "Enable Thread-Sanitizer (currently only supported on GCC and Clang)" OFF)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you group all the options together bellow this comment:

# Build options
# =============

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer not to - if someone want to work on #3754, it would be easy to remove the chunk of code from here and put it to cmake/Sanitizers.cmake.
This way it will start working for the whole repo.

if(ENABLE_TSAN)
message(
WARNING
Expand All @@ -100,6 +100,7 @@ if(ENABLE_TSAN)
add_link_options(-fno-omit-frame-pointer -fsanitize=thread)
endif()

option(ENABLE_USAN "Enable Undefined-Sanitizer (currently only supported on GCC and Clang)" OFF)
mathbunnyru marked this conversation as resolved.
Show resolved Hide resolved
if(ENABLE_USAN)
message(
WARNING
Expand Down
Loading