Updated websocket library and fixed bugs due to reconnects #98
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #97 . I removed unnecessary threads that were being created around
run_forever
.run_forever
already creates a thread so this is a waste of resources. I also discovered the constant reconnect issue was because the connection checker was continuing to run while in reconnect mode. This was because of a bad state check. We now kill the connection checker no matter what whenstop()
is called. I also updated the websocket-client library because it was very out of date. This resolved all my issues and seemed to introduce no additional problems in my testing.This library seems like it might be dead but I hope you'll consider this PR. I'd hate to have to maintain a fork just to fix this bug :(