Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate passing str as an argument #52

Merged
merged 3 commits into from
Aug 19, 2022
Merged

Deprecate passing str as an argument #52

merged 3 commits into from
Aug 19, 2022

Conversation

manicmaniac
Copy link
Owner

@manicmaniac manicmaniac commented Aug 19, 2022 •
edited
Loading

#51

  • Warn deprecation when str is passed as argument
  • Fix test cases
  • Fix examples in README

@manicmaniac manicmaniac self-assigned this Aug 19, 2022
@manicmaniac manicmaniac changed the title deprecate str args Deprecate passing str as an argument Aug 19, 2022
@manicmaniac manicmaniac force-pushed the deprecate-str-args branch 2 times, most recently from 5d28ff1 to 13d4ff2 Compare August 19, 2022 13:30
@manicmaniac manicmaniac merged commit aeb4256 into master Aug 19, 2022
@manicmaniac manicmaniac deleted the deprecate-str-args branch August 19, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@manicmaniac manicmaniac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@manicmaniac