Numpy-related fixes and deprecations #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @vnmanoharan! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-12-26 23:25:23 UTC |
kaitorrens
approved these changes
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #435, we are targeting numpy 1.20.3 for HoloPy 3.6. This PR fixes some code that uses numpy constructs that will not work in later numpy versions (>1.20.3) . These fixes will allow us to more easily transition to numpy version 2 in later versions of HoloPy.
This PR also deprecates passing the
nameargument to a numpy ufunc to create a TransformedPrior, a feature that was added in HoloPy 3.5. Unfortunately, versions of numpy >1.20.3 have added argument validation for ufuncs, so that trying to create aTranformedPriorobject by doing, for example,transformed = np.sqrt(prior_1, name=new_name)will fail on these later numpy versions with aTypeError. ADeprecationWarningis now issued, and the feature will be removed in HoloPy 3.7. Documentation has been updated to no longer discuss this feature, and a test has been added to check for theDeprecationWarning.