config,lfsapi: return last element of gitconfig, not first

manoraj · Apr 14, 2017 · 34d590c · 34d590c
1 parent 8b2964f
commit 34d590c
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/config/git_fetcher.go b/config/git_fetcher.go
@@ -47,7 +47,7 @@ func ReadGitConfig(configs ...*GitConfig) (gf *GitFetcher, extensions map[string
 			key, val := strings.ToLower(pieces[0]), pieces[1]
 
 			if origKey, ok := uniqKeys[key]; ok {
-				if ShowConfigWarnings && len(vals[key]) > 0 && vals[key][0] != val && strings.HasPrefix(key, gitConfigWarningPrefix) {
+				if ShowConfigWarnings && len(vals[key]) > 0 && vals[key][len(vals[key])-1] != val && strings.HasPrefix(key, gitConfigWarningPrefix) {
 					fmt.Fprintf(os.Stderr, "WARNING: These git config values clash:\n")
 					fmt.Fprintf(os.Stderr, "  git config %q = %q\n", origKey, vals[key])
 					fmt.Fprintf(os.Stderr, "  git config %q = %q\n", pieces[0], val)
@@ -124,7 +124,7 @@ func (g *GitFetcher) Get(key string) (val string, ok bool) {
 	if len(all) == 0 {
 		return "", false
 	}
-	return all[0], true
+	return all[len(all)-1], true
 }
 
 func (g *GitFetcher) GetAll(key string) []string {

diff --git a/config/map_fetcher.go b/config/map_fetcher.go
@@ -24,7 +24,7 @@ func (m mapFetcher) Get(key string) (val string, ok bool) {
 	if len(all) == 0 {
 		return "", false
 	}
-	return all[0], true
+	return all[len(all)-1], true
 }
 
 // Get implements the func `Fetcher.GetAll`.

diff --git a/lfsapi/endpoint_finder.go b/lfsapi/endpoint_finder.go
@@ -282,9 +282,9 @@ func initAliases(e *endpointGitFinder, git Env) {
 		if len(gitval) == 0 || !(strings.HasPrefix(gitkey, prefix) && strings.HasSuffix(gitkey, suffix)) {
 			continue
 		}
-		if _, ok := e.aliases[gitval[0]]; ok {
+		if _, ok := e.aliases[gitval[len(gitval)-1]]; ok {
 			fmt.Fprintf(os.Stderr, "WARNING: Multiple 'url.*.insteadof' keys with the same alias: %q\n", gitval)
 		}
-		e.aliases[gitval[0]] = gitkey[len(prefix) : len(gitkey)-len(suffix)]
+		e.aliases[gitval[len(gitval)-1]] = gitkey[len(prefix) : len(gitkey)-len(suffix)]
 	}
 }
diff --git a/lfsapi/lfsapi.go b/lfsapi/lfsapi.go
@@ -215,7 +215,7 @@ func (e TestEnv) Get(key string) (string, bool) {
 	if len(all) == 0 {
 		return "", false
 	}
-	return all[0], true
+	return all[len(all)-1], true
 }
 
 func (e TestEnv) GetAll(key string) []string {