add refs/stash and tests

manoraj · Jun 15, 2022 · 42b4bc2 · 42b4bc2
1 parent 4d1004b
commit 42b4bc2
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/commands/command_migrate.go b/commands/command_migrate.go
@@ -128,6 +128,13 @@ func rewriteOptions(args []string, opts *githistory.RewriteOptions, l *tasklog.L
 // isSpecialGitRef checks if a ref spec is a special git ref to exclude from
 // --everything
 func isSpecialGitRef(refspec string) bool {
+	// Special refspecs.
+	switch refspec {
+	case "refs/stash":
+		return true
+	}
+
+	// Special refspecs from namespaces.
 	parts := strings.SplitN(refspec, "/", 3)
 	if len(parts) < 3 {
 		return false

diff --git a/commands/commands_test.go b/commands/commands_test.go
@@ -47,3 +47,11 @@ func TestDetermineIncludeExcludePathsReturnsNothingWhenAbsent(t *testing.T) {
 	assert.Empty(t, i)
 	assert.Empty(t, e)
 }
+
+func TestSpecialGitRefsExclusion(t *testing.T) {
+	assert.True(t, isSpecialGitRef("refs/notes/commits"))
+	assert.True(t, isSpecialGitRef("refs/bisect/bad"))
+	assert.True(t, isSpecialGitRef("refs/replace/abcdef90"))
+	assert.True(t, isSpecialGitRef("refs/stash"))
+	assert.False(t, isSpecialGitRef("refs/commits/abcdef90"))
+}