commands,git,lfs: invert RemoteRefs() tags option

As suggested by larsxschneider on PR review, we can avoid one
negation of the new Boolean argument we have added to the RemoteRefs()
function in our "git" package, in a prior commit in this PR, if we
invert the flag's sense and rename it from ignoreTags to withTags.

We also take the opportunity to update the code comments which describe
the action of the RemoteRefs() function so as to indicate that the
inclusion of tag refs in the returned list of refs is now optional.

commands/command_migrate.go

@@ -276,7 +276,7 @@ func getRemoteRefs(l *tasklog.Logger) (map[string][]*git.Ref, error) {
 		if migrateSkipFetch {
 			refsForRemote, err = git.CachedRemoteRefs(remote)
 		} else {
-			refsForRemote, err = git.RemoteRefs(remote, false)
+			refsForRemote, err = git.RemoteRefs(remote, true)
 		}
 
 		if err != nil {

git/git.go

@@ -1277,12 +1277,12 @@ func Fetch(remotes ...string) error {
 	return err
 }
 
-// RemoteRefs returns a list of branches & tags for a remote by actually
-// accessing the remote via git ls-remote.
-func RemoteRefs(remoteName string, ignoreTags bool) ([]*Ref, error) {
+// RemoteRefs returns a list of branches and, optionally, tags for a remote
+// by actually accessing the remote via git ls-remote.
+func RemoteRefs(remoteName string, withTags bool) ([]*Ref, error) {
 	var ret []*Ref
 	args := []string{"ls-remote", "--heads", "-q"}
-	if !ignoreTags {
+	if withTags {
 		args = append(args, "--tags")
 	}
 	args = append(args, remoteName)
@@ -1308,7 +1308,7 @@ func RemoteRefs(remoteName string, ignoreTags bool) ([]*Ref, error) {
 
 			typ := RefTypeRemoteBranch
 			if ns == "tags" {
-				if ignoreTags {
+				if !withTags {
 					return nil, errors.New(tr.Tr.Get("unexpected tag returned by `git ls-remote --heads`: %s %s", name, sha))
 				}
 				typ = RefTypeRemoteTag

lfs/gitscanner_remotes.go

@@ -16,7 +16,7 @@ func calcSkippedRefs(remote string) []string {
 
 	// Since CachedRemoteRefs() only returns branches, request that
 	// RemoteRefs() ignore tags and also return only branches.
-	actualRemoteRefs, _ := git.RemoteRefs(remote, true)
+	actualRemoteRefs, _ := git.RemoteRefs(remote, false)
 
 	// The list of remote refs can be very large, so convert them to
 	// a set for faster lookups in the skip calculation loop.