Run end-of-file-fixer on the repository

.clang-tidy

@@ -25,4 +25,3 @@ Checks: >
 # -modernize-use-trailing-return-type           We use the old style throughout
 
 # -readability-implicit-bool-conversion         Allow if(!ptr) rather than (ptr==nullptr)
-

Framework/API/inc/MantidAPI/RegionSelectorObserver.h

@@ -14,4 +14,4 @@ class MANTID_API_DLL RegionSelectorObserver {
   virtual ~RegionSelectorObserver();
   virtual void notifyRegionChanged() = 0;
 };
-} // namespace Mantid::API
+} // namespace Mantid::API

Framework/API/inc/MantidAPI/WorkspacePropertyUtils.h

@@ -18,4 +18,4 @@ MANTID_API_DLL void setPropertyModeForWorkspaceProperty(Mantid::Kernel::Property
                                                         const PropertyMode::Type &optional);
 
 }
-} // namespace Mantid
+} // namespace Mantid

Framework/API/src/AlgoTimeRegister.cpp

@@ -92,4 +92,4 @@ AlgoTimeRegisterImpl::AlgoTimeRegisterImpl()
 AlgoTimeRegisterImpl::~AlgoTimeRegisterImpl() {}
 
 } // namespace Instrumentation
-} // namespace Mantid
+} // namespace Mantid

Framework/API/src/AlgorithmFactoryObserver.cpp

@@ -62,4 +62,4 @@ void AlgorithmFactoryObserver::_updateHandle(AlgorithmFactoryUpdateNotification_
   this->updateHandle();
 }
 
-} // namespace Mantid::API
+} // namespace Mantid::API

Framework/API/src/AnalysisDataServiceObserver.cpp

@@ -290,4 +290,4 @@ void AnalysisDataServiceObserver::_groupUpdateHandle(
   this->groupUpdateHandle(pNf->objectName(), pNf->object());
 }
 
-} // namespace Mantid::API
+} // namespace Mantid::API

Framework/API/src/Citation.cpp

@@ -79,4 +79,4 @@ void Citation::saveNexus(::NeXus::File *file, const std::string &group) {
   file->closeGroup();
 }
 
-} // namespace Mantid::API
+} // namespace Mantid::API

Framework/API/src/InstrumentFileFinder.cpp

@@ -302,4 +302,4 @@ void InstrumentFileFinder::getValidFromTo(const std::string &IDFfilename, std::s
   }
 }
 
-} // Namespace Mantid::API
+} // Namespace Mantid::API

Framework/API/src/WorkspacePropertyUtils.cpp

@@ -44,4 +44,4 @@ void MANTID_API_DLL setPropertyModeForWorkspaceProperty(Mantid::Kernel::Property
 }
 
 } // namespace API
-} // namespace Mantid
+} // namespace Mantid

Framework/API/test/FunctionAttributeValidatorTest.h

@@ -230,4 +230,4 @@ class FunctionAttributeValidatorTest : public CxxTest::TestSuite {
     v[2] = 10;
     TS_ASSERT_THROWS(f.declareVecArrayBoundedAttr("VAttr_invalid", v, 1.0, 5.0), IFunction::ValidationException &);
   }
-};
+};

Framework/API/test/InstrumentFileFinderTest.h

@@ -190,4 +190,4 @@ class InstrumentFileFinderTest : public CxxTest::TestSuite {
     TS_ASSERT(!path.empty());
     TS_ASSERT(boost::regex_match(path, boost::regex(".*LOKI_Definition\\.hdf5$")));
   }
-};
+};

Framework/API/test/ResultTest.h

@@ -71,4 +71,4 @@ class ResultTest : public CxxTest::TestSuite {
     TS_ASSERT_EQUALS("Error", testResult.errors());
     TS_ASSERT_EQUALS(in, testResult.result());
   }
-};
+};

Framework/Algorithms/inc/MantidAlgorithms/AddAbsorptionWeightedPathLengths.h

@@ -54,4 +54,4 @@ class MANTID_ALGORITHMS_DLL AddAbsorptionWeightedPathLengths final : public API:
 };
 
 } // namespace Algorithms
-} // namespace Mantid
+} // namespace Mantid

Framework/Algorithms/inc/MantidAlgorithms/FindPeaksConvolve.h

@@ -103,4 +103,4 @@ class MANTID_ALGORITHMS_DLL FindPeaksConvolve : public API::Algorithm {
                                                  const std::vector<std::string> &outputTblNames);
 };
 
-} // namespace Mantid::Algorithms
+} // namespace Mantid::Algorithms

Framework/Algorithms/inc/MantidAlgorithms/PolarizationCorrections/HeliumAnalyserEfficiency.h

@@ -54,4 +54,4 @@ class MANTID_ALGORITHMS_DLL HeliumAnalyserEfficiency final : public API::Algorit
   static const double ABSORPTION_CROSS_SECTION_CONSTANT;
 };
 } // namespace Algorithms
-} // namespace Mantid
+} // namespace Mantid

Framework/Algorithms/inc/MantidAlgorithms/PolarizationCorrections/PolarizationCorrectionsHelpers.h

@@ -49,4 +49,4 @@ auto constexpr MINUS = "-";
 auto constexpr PLUS = "+";
 } // namespace SpinStateConfigurationsWildes
 
-} // namespace Mantid::Algorithms
+} // namespace Mantid::Algorithms

Framework/Algorithms/inc/MantidAlgorithms/PolarizationCorrections/PolarizerEfficiency.h

@@ -42,4 +42,4 @@ class MANTID_ALGORITHMS_DLL PolarizerEfficiency final : public API::Algorithm {
 };
 
 } // namespace Algorithms
-} // namespace Mantid
+} // namespace Mantid

Framework/Algorithms/src/FindPeaksConvolve.cpp

@@ -484,4 +484,4 @@ double FindPeaksConvolve::PeakResult::getAttribute(const std::string &attrString
     return -1.0;
   }
 }
-} // namespace Mantid::Algorithms
+} // namespace Mantid::Algorithms

Framework/Algorithms/src/PDFFourierTransform.cpp

@@ -382,4 +382,4 @@ void PDFFourierTransform::exec() {
   setProperty("OutputWorkspace", outputWS);
 }
 
-} // namespace Mantid::Algorithms
+} // namespace Mantid::Algorithms

Framework/Algorithms/src/PDFFourierTransform2.cpp

@@ -544,4 +544,4 @@ void PDFFourierTransform2::exec() {
   setProperty("OutputWorkspace", outputWS);
 }
 
-} // namespace Mantid::Algorithms
+} // namespace Mantid::Algorithms

Framework/Algorithms/src/PolarizationCorrections/HeliumAnalyserEfficiency.cpp

@@ -265,4 +265,4 @@ double HeliumAnalyserEfficiency::calculateTCrit(const size_t numberOfBins) {
   }
   return tPpf;
 }
-} // namespace Mantid::Algorithms
+} // namespace Mantid::Algorithms

Framework/Algorithms/src/PolarizationCorrections/PolarizationCorrectionsHelpers.cpp

@@ -59,4 +59,4 @@ std::vector<std::string> splitSpinStateString(const std::string &spinStates) {
   StringTokenizer tokens{spinStates, ",", StringTokenizer::TOK_TRIM};
   return std::vector<std::string>{tokens.begin(), tokens.end()};
 }
-} // namespace Mantid::Algorithms::PolarizationCorrectionsHelpers
+} // namespace Mantid::Algorithms::PolarizationCorrectionsHelpers

Framework/Algorithms/src/Q1D2.cpp

@@ -626,4 +626,4 @@ void Q1D2::normalize(const HistogramData::HistogramY &normSum, const HistogramDa
     errors[k] = std::sqrt(errors[k] / (c * c) + normError2[k] * aOverc * aOverc);
   }
 }
-} // namespace Mantid::Algorithms
+} // namespace Mantid::Algorithms

Framework/Algorithms/test/AddAbsorptionWeightedPathLengthsTest.h

@@ -214,4 +214,4 @@ class AddAbsorptionWeightedPathLengthsTest : public CxxTest::TestSuite {
         Mantid::Kernel::Material("Vanadium", Mantid::PhysicalConstants::getNeutronAtom(23, 0), 0.072)));
     peaksWS->mutableSample().setShape(shape);
   }
-};
+};

Framework/Algorithms/test/FindPeaksConvolveTest.h

@@ -224,4 +224,4 @@ class FindPeaksConvolveTest : public CxxTest::TestSuite {
         std::dynamic_pointer_cast<Mantid::API::ITableWorkspace>(resultWs->getItem("PeakCentre"));
     TS_ASSERT_EQUALS(item->rowCount(), 6);
   }
-};
+};

Framework/Algorithms/test/FindPeaksTest.h

@@ -486,4 +486,4 @@ class FindPeaksTestPerformance : public CxxTest::TestSuite {
 
   Mantid::API::MatrixWorkspace_sptr m_dataWS;
   Mantid::API::MatrixWorkspace_sptr m_syntheticWS;
-}; // end of class FindPeaksTestPerformance
+}; // end of class FindPeaksTestPerformance

Framework/Algorithms/test/PlusMinusTest.in.h

@@ -1184,5 +1184,3 @@ class @PLUSMINUSTEST_CLASS@Performance : public CxxTest::TestSuite
   }
 
 }; // end of class @PLUSMINUSTEST_CLASS@Performance
-
-

Framework/Algorithms/test/PolarizationCorrections/HeliumAnalyserEfficiencyTest.h

@@ -307,4 +307,4 @@ class HeliumAnalyserEfficiencyTest : public CxxTest::TestSuite {
       TS_ASSERT_DELTA(expectedErrorValues[i], error[i], 1e-7);
     }
   }
-};
+};

Framework/Algorithms/test/PolarizationCorrections/PolarizationCorrectionsHelpersTest.h

@@ -86,4 +86,4 @@ class PolarizationCorrectionsHelpersTest : public CxxTest::TestSuite {
     boost::trim(trimmedInput);
     return trimmedInput;
   }
-};
+};

Framework/Algorithms/test/PolarizationCorrections/PolarizerEfficiencyTest.h

@@ -317,4 +317,4 @@ class PolarizerEfficiencyTest : public CxxTest::TestSuite {
     rebin->setPropertyValue("OutputWorkspace", analyzerWsName);
     rebin->execute();
   }
-};
+};

Framework/Algorithms/test/PolarizationCorrections/SpinStateValidatorTest.h

@@ -115,4 +115,4 @@ class SpinStateValidatorTest : public CxxTest::TestSuite {
       ASSERT_TRUE(result.empty() == shouldBeValid);
     }
   }
-};
+};

Framework/Crystal/inc/MantidCrystal/BackgroundStrategy.h

@@ -22,4 +22,4 @@ class BackgroundStrategy {
   virtual ~BackgroundStrategy() = default;
 };
 } // namespace Crystal
-} // namespace Mantid
+} // namespace Mantid

Framework/Crystal/src/LoadHKL.cpp

@@ -211,4 +211,4 @@ void LoadHKL::exec() {
   setProperty("OutputWorkspace", std::dynamic_pointer_cast<PeaksWorkspace>(ws));
 }
 
-} // namespace Mantid::Crystal
+} // namespace Mantid::Crystal

Framework/Crystal/test/FindUBUsingIndexedPeaksTest.h

@@ -277,4 +277,4 @@ class FindUBUsingIndexedPeaksTest : public CxxTest::TestSuite {
     // Remove workspace from the data service.
     AnalysisDataService::Instance().remove("peaks");
   }
-};
+};

Framework/Crystal/test/IntegratePeakTimeSlicesTest.h

@@ -258,4 +258,4 @@ class IntegratePeakTimeSlicesTest : public CxxTest::TestSuite {
 
     return wsPtr;
   }
-};
+};

Framework/Crystal/test/MaskPeaksWorkspaceTest.h

@@ -168,4 +168,4 @@ class MaskPeaksWorkspaceTestPerformance : public CxxTest::TestSuite {
 private:
   MaskPeaksWorkspace mpwAlg;
   std::string inputWSName = "inputWS";
-};
+};

Framework/Crystal/test/SaveIsawUBTest.h

@@ -234,4 +234,4 @@ class SaveIsawUBTest : public CxxTest::TestSuite {
     auto rotated_ub = ws->sample().getOrientedLattice().getUB();
     TS_ASSERT_DELTA(-1.0, rotated_ub[0][1], 1e-8); // previously 1 in original (unrotated UB)
   }
-};
+};

Framework/CurveFitting/inc/MantidCurveFitting/Algorithms/QENSFitUtilities.h

@@ -22,4 +22,4 @@ void renameWorkspacesInQENSFit(Algorithm *qensFit, IAlgorithm_sptr renameAlgorit
 bool containsMultipleData(const std::vector<MatrixWorkspace_sptr> &workspaces);
 
 } // namespace API
-} // namespace Mantid
+} // namespace Mantid

Framework/CurveFitting/inc/MantidCurveFitting/EigenJacobian.h

@@ -142,4 +142,4 @@ template <class T> class JacobianImpl1 : public API::Jacobian {
 };
 
 } // namespace CurveFitting
-} // namespace Mantid
+} // namespace Mantid

Framework/CurveFitting/inc/MantidCurveFitting/EigenMatrixView.h

@@ -76,4 +76,4 @@ class MANTID_CURVEFITTING_DLL EigenMatrix_View {
   map_type m_view;
   bool m_isConst = false;
 };
-} // namespace Mantid::CurveFitting
+} // namespace Mantid::CurveFitting

Framework/CurveFitting/inc/MantidCurveFitting/EigenVectorView.h

@@ -56,4 +56,4 @@ class MANTID_CURVEFITTING_DLL EigenVector_View {
   vec_map_type m_view;
   bool m_isConst = false;
 };
-} // namespace Mantid::CurveFitting
+} // namespace Mantid::CurveFitting

Framework/CurveFitting/inc/MantidCurveFitting/Functions/MagneticOrderParameter.h

@@ -46,4 +46,4 @@ class MANTID_CURVEFITTING_DLL MagneticOrderParameter : public BackgroundFunction
 
 } // namespace Functions
 } // namespace CurveFitting
-} // namespace Mantid
+} // namespace Mantid

Framework/CurveFitting/inc/MantidCurveFitting/Functions/MuoniumDecouplingCurve.h

@@ -45,4 +45,4 @@ class MANTID_CURVEFITTING_DLL MuoniumDecouplingCurve : public BackgroundFunction
 
 } // namespace Functions
 } // namespace CurveFitting
-} // namespace Mantid
+} // namespace Mantid

Framework/CurveFitting/src/Algorithms/QENSFitUtilities.cpp

@@ -56,4 +56,4 @@ void renameWorkspacesInQENSFit(Algorithm *qensFit, IAlgorithm_sptr renameAlgorit
   renameWorkspacesWith(outputGroup, getName, renamer);
 }
 
-} // namespace Mantid::API
+} // namespace Mantid::API

Framework/CurveFitting/src/EigenMatrixView.cpp

@@ -144,4 +144,4 @@ EigenMatrix_View &EigenMatrix_View::operator=(EigenMatrix_View &&V) {
                          dynamic_stride(V.m_view.outerStride(), V.m_view.innerStride()));
   return *this;
 }
-} // namespace Mantid::CurveFitting
+} // namespace Mantid::CurveFitting

Framework/CurveFitting/src/Functions/ActivationK.cpp

@@ -53,4 +53,4 @@ void ActivationK::functionDeriv1D(Jacobian *out, const double *xValues, const si
   }
 }
 
-} // namespace Mantid::CurveFitting::Functions
+} // namespace Mantid::CurveFitting::Functions

Framework/CurveFitting/src/Functions/ActivationmeV.cpp

@@ -54,4 +54,4 @@ void ActivationmeV::functionDeriv1D(Jacobian *out, const double *xValues, const
   }
 }
 
-} // namespace Mantid::CurveFitting::Functions
+} // namespace Mantid::CurveFitting::Functions

Framework/CurveFitting/src/Functions/CriticalPeakRelaxationRate.cpp

@@ -54,4 +54,4 @@ void CriticalPeakRelaxationRate::function1D(double *out, const double *xValues,
   }
 }
 
-} // namespace Mantid::CurveFitting::Functions
+} // namespace Mantid::CurveFitting::Functions

Framework/CurveFitting/src/Functions/MagneticOrderParameter.cpp

@@ -82,4 +82,4 @@ void MagneticOrderParameter::functionDeriv1D(Jacobian *out, const double *xValue
   }
 }
 
-} // namespace Mantid::CurveFitting::Functions
+} // namespace Mantid::CurveFitting::Functions

Framework/CurveFitting/src/Functions/MuoniumDecouplingCurve.cpp

@@ -53,4 +53,4 @@ void MuoniumDecouplingCurve::functionDeriv1D(Jacobian *out, const double *xValue
   }
 }
 
-} // namespace Mantid::CurveFitting::Functions
+} // namespace Mantid::CurveFitting::Functions

Framework/CurveFitting/src/Functions/PowerLaw.cpp

@@ -51,4 +51,4 @@ void PowerLaw::functionDeriv1D(Jacobian *out, const double *xValues, const size_
   }
 }
 
-} // namespace Mantid::CurveFitting::Functions
+} // namespace Mantid::CurveFitting::Functions

Framework/CurveFitting/src/Functions/SmoothTransition.cpp

@@ -62,4 +62,4 @@ void SmoothTransition::functionDeriv1D(Jacobian *out, const double *xValues, con
   }
 }
 
-} // namespace Mantid::CurveFitting::Functions
+} // namespace Mantid::CurveFitting::Functions

Framework/CurveFitting/test/Algorithms/DoublePulseFitTest.h

@@ -70,4 +70,4 @@ class DoublePulseFitTest : public CxxTest::TestSuite {
         5);
     TS_ASSERT_THROWS(extractInnerFunction(initialFunction), const std::runtime_error &);
   }
-};
+};

Framework/CurveFitting/test/Algorithms/ProfileChiSquared1DTest.h

@@ -153,4 +153,4 @@ class ProfileChiSquared1DTest : public CxxTest::TestSuite {
     TS_ASSERT_EQUALS(pdfTable->rowCount(), 100);
     AnalysisDataService::Instance().clear();
   };
-};
+};

Framework/CurveFitting/test/Algorithms/RefinePowderInstrumentParameters3Test.h

@@ -336,4 +336,4 @@ class RefinePowderInstParams3TestPerformance : public TestSuite {
     alg.setProperty("MonteCarloIterations", 100);
     alg.execute();
   }
-};
+};

Framework/CurveFitting/test/Algorithms/SplineBackgroundTest.h

@@ -147,4 +147,4 @@ class SplineBackgroundTestPerformance : public CxxTest::TestSuite {
   struct SinFunction {
     double operator()(double x, int) { return std::sin(x); }
   };
-};
+};

Framework/CurveFitting/test/Algorithms/SplineInterpolationTest.h

@@ -272,4 +272,4 @@ class SplineInterpolationTestPerformance : public CxxTest::TestSuite {
   struct SplineFunc {
     double operator()(double x, int) { return x * 2; }
   };
-};
+};