Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1013: NeXus Loading Window #1024

Merged
merged 81 commits into from
Jun 28, 2021
Merged

1013: NeXus Loading Window #1024

merged 81 commits into from
Jun 28, 2021

Conversation

DolicaAkelloEgwel
Copy link
Collaborator

@DolicaAkelloEgwel DolicaAkelloEgwel commented Jun 17, 2021 •
edited
Loading

Issue

Closes #1013

Description

Adds a NeXus Loading window that scans the file and asks the user which images they want to use.

Testing

Created a new NexusLoaderTest class for the presenter tests that are mostly the same as the previous tests.

Acceptance Criteria

Check that

  • The NeXus loader window displays the contents of the NeXus file
  • Image types can't be selected if they're not in the NeXus file
  • The OK button is disabled unless a valid NeXus file has been chosen
  • Selecting another NeXus file resets the table widget

Documentation

Updated the release notes. Also updates the NeXus loading information in the user docs.

@DolicaAkelloEgwel
new files
b1165a1
@DolicaAkelloEgwel
window appearing
0f6fc9d
@DolicaAkelloEgwel
adding items to list
cf6dd85
@DolicaAkelloEgwel
pixel size and bit depth
9b39363
@DolicaAkelloEgwel
widget names
dd4979a
@DolicaAkelloEgwel
choose nexus file and change line edit
003ab98
@DolicaAkelloEgwel
moving nexus loader methods
ff2e9ac
@DolicaAkelloEgwel
Merge branch 'master' into 1013_nexus_loading_window
5abc5d1
@DolicaAkelloEgwel
updating when image key is found
bb21ea2
@DolicaAkelloEgwel
data tree
b188e1b
@DolicaAkelloEgwel
flat/dark before/after
1e87244
@DolicaAkelloEgwel
not used at the moment
e19e8cd
@DolicaAkelloEgwel
better column sizing
30e6b66
@DolicaAkelloEgwel
baggage not needed
3557b17
@DolicaAkelloEgwel
fixing paths
7b373f9
@DolicaAkelloEgwel
array sizes
4666612
@DolicaAkelloEgwel
Merge branch 'master' into 1013_nexus_loading_window
bc7b19f
@DolicaAkelloEgwel
helper methods
db42ded
@DolicaAkelloEgwel
can't not use projections
c81d5c8
@DolicaAkelloEgwel
empty invalid file opened method
d6631f1
@DolicaAkelloEgwel
just using get_images for flat/dark arrays
52e25b4
@DolicaAkelloEgwel
using set text rather than label like a baka
864208c
@DolicaAkelloEgwel
some constants
5a92b99
@DolicaAkelloEgwel
renaming methods
7368fd4
@DolicaAkelloEgwel
Merge branch 'master' into 1013_nexus_loading_window
4eee557
@DolicaAkelloEgwel
set found status method
c00708a
@DolicaAkelloEgwel
changing state of OK button
7ebd6b3
@DolicaAkelloEgwel
remove repeat log message
73b307f
@DolicaAkelloEgwel
Merge branch 'master' into 1013_nexus_loading_window
72fb5bb
@DolicaAkelloEgwel
clearing columns when file is chosen
47e1b65
@samtygier-stfc samtygier-stfc added this to the Sprint 2021-06-21 milestone Jun 21, 2021
@DolicaAkelloEgwel DolicaAkelloEgwel marked this pull request as ready for review June 25, 2021 11:18
samtygier-stfc
samtygier-stfc approved these changes Jun 28, 2021
View reviewed changes
Copy link
Collaborator

@samtygier-stfc samtygier-stfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good. Works well.

@samtygier-stfc samtygier-stfc merged commit 4983d03 into master Jun 28, 2021
@samtygier-stfc samtygier-stfc deleted the 1013_nexus_loading_window branch June 28, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samtygier-stfc samtygier-stfc samtygier-stfc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sprint 2021-06-21
Development

Successfully merging this pull request may close these issues.

NeXus: Loading window
2 participants
@DolicaAkelloEgwel @samtygier-stfc