Image view indicators for NaNs #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtygier-stfc
force-pushed
the
1167-image-view-indicators
branch
2 times, most recently
from
a2647e9
to
bbc50d4
Compare
An indicator icon that can be added to ViewBox.
samtygier-stfc
force-pushed
the
1167-image-view-indicators
branch
from
bbc50d4
to
416d0c6
Compare
Add accessor for image, and use it. This ensure that all calls to setImage can be seen by MIMiniImageView.
Can be used with MIImageView and MIMiniImageView to show an indicator when there is bad data present in an image view.
Found by applitools
|
2 of the GUI tests now show the indicator. test_negative_nan_overlay and test_operations_rescale_parameters (due to #1183). test_operations_ROI_normalisation_parameters had a subtle change with slight variation in image size compared to the baseline |
samtygier-stfc
changed the title
DolicaAkelloEgwel
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #1167
Description
Implement a
BadDataOverlaymixin that can be used byMIImageViewandMIMiniImageViewto indicate when the current slice has NaN pixels in it.Made sure that the
setImagemethod is always called throughMIImageViewandMIMiniImageViewso that they can trigger the check. ForMIImageViewthe check also called when moving through the slices ("timeline")Testing & Acceptance Criteria
Open a data set with nans, check that the bad data indicator shows in the the main, operations and recon windows.
I have not added unit tests as this is well covered by the GUI tests.
Documentation
Release notes