Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute Operation ring removal #2128

Closed
wants to merge 7 commits into from
Closed

Compute Operation ring removal #2128

wants to merge 7 commits into from

Conversation

ashmeigh
Copy link
Collaborator

@ashmeigh ashmeigh commented Mar 12, 2024

Issue

This issue was part of #2051

Description

This pull request addresses the ongoing effort to standardize the execution of operations by transitioning from the partial function style to a structured compute_function approach. In this update, several operations have been refactored to adhere to the new standard. The modifications ensure a clearer separation between the setup and execution phases of each operation, improving the maintainability and readability of the codebase.

Changes

Refactored multiple operations to implement the new compute_function approach.
Introduced static methods compute_function in each affected operation module to encapsulate the core logic for executing the operation on a per-slice basis.
Updated the calling code to use the compute_function method instead of the previous partial function style

@coveralls
Copy link

coveralls commented Mar 12, 2024

Coverage Status

coverage: 74.291% (-0.008%) from 74.299%
when pulling 450d05a on Compute_Ring_Remove-
into db14d23 on main.

@samtygier-stfc
Copy link
Collaborator

This is failing the check for me, if I run the compare script with options -m compare -k "ring removal" --gui it will show the baseline, new and difference. It looks like something is not working

image

@ashmeigh
Copy link
Collaborator Author

Closing this PR as further multithreading within the ring removal process appears unnecessary. Benchmarking reveals that the current implementation in the tomopy library already efficiently utilizes multithreading. If there are other areas where performance enhancements are needed, feel free to explore and suggest improvements.

@ashmeigh ashmeigh closed this Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants