Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute rescale operation #2130

Merged
merged 4 commits into from
Mar 13, 2024
Merged

Compute rescale operation #2130

merged 4 commits into from
Mar 13, 2024

Conversation

ashmeigh
Copy link
Collaborator

@ashmeigh ashmeigh commented Mar 12, 2024

Issue

This issue was part of #2051

Description

This pull request addresses the ongoing effort to standardize the execution of operations by transitioning from the partial function style to a structured compute_function approach. In this update, several operations have been refactored to adhere to the new standard. The modifications ensure a clearer separation between the setup and execution phases of each operation, improving the maintainability and readability of the codebase.

Changes

Refactored multiple operations to implement the new compute_function approach.
Introduced static methods compute_function in each affected operation module to encapsulate the core logic for executing the operation on a per-slice basis.
Updated the calling code to use the compute_function method instead of the previous partial function style

@coveralls
Copy link

coveralls commented Mar 12, 2024

Coverage Status

coverage: 74.31% (+0.01%) from 74.299%
when pulling 0d4604f on Compute_Rescale
into db14d23 on main.

Copy link
Collaborator

@samtygier-stfc samtygier-stfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@samtygier-stfc samtygier-stfc added this pull request to the merge queue Mar 13, 2024
Merged via the queue into main with commit bb51655 Mar 13, 2024
8 checks passed
@samtygier-stfc samtygier-stfc deleted the Compute_Rescale branch March 13, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants