Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Processes setting to the Settings Window #2157

Merged
merged 3 commits into from
Apr 22, 2024

Conversation

MikeSullivan7
Copy link
Collaborator

@MikeSullivan7 MikeSullivan7 commented Apr 3, 2024

Issue

Closes #2154.

Description

This PR requires PR #2144 to be merged first.
A Performance tab has been added to the settings window with a spinbox to choose the number of processes to use in the pool upon first start up.
At default, this uses 8 processes.

Currently a minimum of 1 and a maximum of 16 must be chosen.

Testing

make check

Acceptance Criteria

  • Start MI and check that 8 processes are in the pool upon startup.
  • In the Settings window, change the number of processes to any other number.
  • check that you cant choose <1 or >16 processes.
  • restart MI and check that the correct number of processes start in the pool

Documentation

Will add release note

@coveralls
Copy link

coveralls commented Apr 3, 2024

Coverage Status

coverage: 73.358% (-0.02%) from 73.378%
when pulling 3fc422c on 2154_processes_GUI_setting
into ea787c4 on main.

@MikeSullivan7 MikeSullivan7 self-assigned this Apr 4, 2024
@MikeSullivan7 MikeSullivan7 marked this pull request as ready for review April 15, 2024 12:36
mantidimaging/gui/windows/settings/presenter.py Outdated Show resolved Hide resolved
mantidimaging/gui/windows/settings/view.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@samtygier-stfc samtygier-stfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@samtygier-stfc samtygier-stfc added this pull request to the merge queue Apr 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 22, 2024
@samtygier-stfc samtygier-stfc added this pull request to the merge queue Apr 22, 2024
Merged via the queue into main with commit b370ba9 Apr 22, 2024
8 checks passed
@samtygier-stfc samtygier-stfc deleted the 2154_processes_GUI_setting branch April 22, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

GUI configuration for number of processes in pool
3 participants