-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for Monitor Normalisation: #2215
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking as "Request Changes" just to note the things we discussed.
- Fixes to loading using
filename_group.find_log_file()
- Updating so that this does not remove the Circular Mask from the test_cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good now. Just needs the flat/dark lines dropping out of this PR
elif test_case.pre_run_step == 'add_flats_and_darks': | ||
self.add_flats_and_darks(test_case.params) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These 2 lines have sneaked in from another branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working well now. Code is good.
Issue
Add test for Monitor Normalisation
Description
This pull of request introduces the load_monitor_log method, which enhances the log file handling process and integrates JSON configuration for monitor normalization settings. This update aims to improve both flexibility and error management.
Testing
Ensure that log files are accurately identified and loaded.
Confirmed the correct application of settings from JSON configurations.
Verified integration does not disrupt existing functionality.
Acceptance Criteria
Run the updated tests to check both log file handling and JSON configuration effects