Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

770: Move shared array allocation to multiprocessing.Array when on Python 3.8 #856

Merged
merged 4 commits into from
Feb 16, 2021

Conversation

DolicaAkelloEgwel
Copy link
Collaborator

@DolicaAkelloEgwel DolicaAkelloEgwel commented Feb 11, 2021

Issue

Closes #770

Description

Replaces multiprocessing.heap with multiprocessing.Array

Testing

n/a

Acceptance Criteria

Check that the existing tests still pass.
Go through the test described in #762 (comment)

Documentation

Updated the release notes.

@DolicaAkelloEgwel DolicaAkelloEgwel changed the title Commenting out heap things 770: Move shared array allocation to multiprocessing.Array when on Python 3.8 Feb 12, 2021
@DolicaAkelloEgwel DolicaAkelloEgwel added this to the Sprint 29-01-2021 milestone Feb 12, 2021
@DolicaAkelloEgwel DolicaAkelloEgwel marked this pull request as ready for review February 12, 2021 13:16
@DolicaAkelloEgwel DolicaAkelloEgwel marked this pull request as draft February 12, 2021 17:45
@DolicaAkelloEgwel DolicaAkelloEgwel marked this pull request as ready for review February 15, 2021 12:44
Copy link
Collaborator

@samtygier-stfc samtygier-stfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Working well for me locally.

@samtygier-stfc samtygier-stfc merged commit 800f235 into master Feb 16, 2021
@samtygier-stfc samtygier-stfc deleted the 770_move_shared_array_allocation branch February 16, 2021 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move shared array allocation to multiprocessing.Array when on Python 3.8
2 participants