Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pnpm): support what pnpm resolves after install #58

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

RyanClementsHax
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Typescript would resolve to a version not supported by the angular compiler and angular had a hard time with :host styles when installing with pnpm.

Issue Number: N/A

What is the new behavior?

Pin typescript to ~5.4.4 and use @HostBinding instead of :host

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@RyanClementsHax RyanClementsHax merged commit b25bd44 into main Jun 21, 2024
2 checks passed
@RyanClementsHax RyanClementsHax deleted the fix/support-pnpm-resolutions-with-vite branch June 21, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant