Pre-commit checking via Source Integration #114
Conversation
…st the user the ticket is assigned to and the Mantis project it is within)
…checking and just reports status back to the hook
|
Thanks for your contribution. It looks like an interesting feature, but I unfortunately really don't have the time to review your code at the moment, so it's likely that your pull request will remain open for some time. Please bear with me. |
|
No problem, I know how it is :-) Glad that you'd consider accepting the pull request - we previously used ScmBug for this kind of checking, but unfortunately it doesn't seem to be maintained any more (and throws dire warnings when using it with more modern versions of the software it interfaces with than were available at the time of the last release). On more than one occasion it has helped to prevent accidents, such as committing against the wrong (or a non-existent) ticket due to a transpositional error when typing the ticket number into the comment! Let me know if there's anything I can do to help out - more than happy to make changes, etc. |
Add cmd line parameters to curl invokation in order to prevent the status report being shown, e.g.:
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 169 100 85 100 84 4856 4799 --:--:-- --:--:-- --:--:-- 5000
Add a check upon bug closure as to the user's permissions with respect to the project prior to assigning the bug to them
Use Vagrant to set up a virtual machine, install Apache, MySQL, etc & then run some tests against the commit checking functionality
Write up of the changes
Essentially it's implementing similar functionality to that which was previously provided by ScmBug, using the information in Mantis to validate commits via a pre-commit hook.
If you're happy with this I'll plan to add support for other version control systems. Please let me know if any changes are required before you'll accept this.
Thanks,
John