-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes for issue #43 (Shortcut for multiple object properties) #45
base: master
Are you sure you want to change the base?
Conversation
4865f84
to
4fd1bcc
Compare
@anikolaev thank you for your work! I'll take a closer look the next couple of days. Sorry for the delay, I've got a lot of stuff to do currently. |
Hey @maoberlehner, sorry to bother but this actually seems to be the perfect solution for some difficulties that I'm having using |
@maoberlehner thanks for the great package it's very simplify my way in project. But I have the problem with fields that does not exist. Could you please review and merge pull-request? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert the yarn.lock
file. Thx!
Additionally, I find it confusing that the API of mapObjectFields()
and mapFields()
is pretty much the same. I'd find it hard to explain that in the documentation. Btw: please also update the documentation in the README.md ;)
I'd love to have the functionality from mapObjectFields()
merged into mapFields()
if this is possible?
Thanks for the great work so far!
@maoberlehner One of previous yarn versions added these integrity lines. Now they only add them for changed modules. Reverted. Yes, I think integration of |
Hi. |
Can someone revert the yarn.lock? |
@anikolaev looks like there are failing tests here. Can you address this? |
Changes for issue #43 :
mapObjectFields()
to add object properties using template e.g.'property.*'
or'*'