added banner to notify user to enable precise location during turn-by-turn navigation #2693
Conversation
…ontroller to optional downcasting, changed PassiveLocationManager to use fullAccuracy instead of forced downcasting
| @@ -367,6 +367,7 @@ open class NavigationViewController: UIViewController, NavigationStatusPresenter | |||
| showStatus(title: title, spinner: false, duration: 3, animated: true, interactive: false) | |||
| } | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
I think we can remove the extra white space.
|
|
||
| if #available(iOS 14.0, *), accuracyAuthorization == .reducedAccuracy { | ||
| let title = NSLocalizedString("ENABLE_PRECISE_LOCATION", bundle: .mapboxNavigation, value: "Enable precise location to navigate", comment: "Label indicating precise location is off and needs to be turned on to navigate") | ||
| showStatus(title: title, spinner: false, duration: 20, animated: true, interactive: false) |
There was a problem hiding this comment.
Is there a way to make this status stay up until precise location is enabled, or is that the focus of another issue?
There was a problem hiding this comment.
Before merging, please open an issue to track persisting this banner until precise location is reenabled, so that we don’t lose track of that important detail. #2691 is sort of related, but I think persisting the accuracy authorization banner and automatically hiding it at the right time would be more tractable, because we’re already observing the notification that we need to observe to know when to hide the banner.
MaximAlien
added
iOS
UI
| /** | ||
| Posted when user changes location authorization settings. | ||
|
|
||
| The user info dictionary indicates which keys and values changed. |
There was a problem hiding this comment.
| The user info dictionary indicates which keys and values changed. | |
| The user info dictionary contains the key `MapboxNavigationService.NotificationUserInfoKey.locationAuthorizationKey`. |
| } | ||
|
|
||
| /** | ||
| A key in the user info dictionary of a `Notification.Name.locationAuthorizationDidChange` notification. The corresponding value is a `Int` object the current location authorization setting. */ |
There was a problem hiding this comment.
It’s technically an Int when we put it in the dictionary, due to our internal workaround, but the developer would be expected to cast it to a CLAccuracyAuthorization.
If the developer needs to similarly work around the lack of CLAccuracyAuthorization on iOS 13, they’d conditionally implement an enumeration on iOS 13 that would match a typedef on iOS 14. But documenting that workaround is probably outside the scope of the documentation here, since the workaround requires a modicum of Objective-C code that might not be appropriate for every application.
| A key in the user info dictionary of a `Notification.Name.locationAuthorizationDidChange` notification. The corresponding value is a `Int` object the current location authorization setting. */ | |
| A key in the user info dictionary of a `Notification.Name.locationAuthorizationDidChange` notification. The corresponding value is a `CLAccuracyAuthorization` indicating the current location authorization setting. */ |
|
|
||
| if #available(iOS 14.0, *), accuracyAuthorization == .reducedAccuracy { | ||
| let title = NSLocalizedString("ENABLE_PRECISE_LOCATION", bundle: .mapboxNavigation, value: "Enable precise location to navigate", comment: "Label indicating precise location is off and needs to be turned on to navigate") | ||
| showStatus(title: title, spinner: false, duration: 20, animated: true, interactive: false) |
There was a problem hiding this comment.
Before merging, please open an issue to track persisting this banner until precise location is reenabled, so that we don’t lose track of that important detail. #2691 is sort of related, but I think persisting the accuracy authorization banner and automatically hiding it at the right time would be more tractable, because we’re already observing the notification that we need to observe to know when to hide the banner.
…ationUserInfoKey struct, fixed CoreConstants comments to be more clear to developers
jill-cardamon
deleted the
jill-enable-precise-location-status-bar-2555
branch
jill-cardamon
restored the
jill-enable-precise-location-status-bar-2555
branch
jill-cardamon
deleted the
jill-enable-precise-location-status-bar-2555
branch
|
Fixed a change (commit hash: 9295eb9) that I accidentally deleted. |
Added banner to notify a user to enable precise location during turn-by-turn navigation using
CLLocationManagerandlocationDidChangeAuthorization(..), bringing this value up the delegate chain. Banner displays for 9 seconds (about the time it takes for a user to notice the banner and change their settings).fix #2555
/cc @mapbox/navigation-ios