Allow the use of multiple status banners#2747

Merged

jill-cardamon merged 40 commits intomainfrom jill-enable-precise-location-tailwork-2723

Mar 11, 2021

+312-33

Commits on Mar 5, 2021

created struct to represent showStatus, refactored relevant files, started new show/hide implementation and subsequent status management
Jill Cardamon
committed
statuses append correctly and don't duplicate, continued work on showing and hiding banners
Jill Cardamon
committed
added show and hide to manageStatuses() method
Jill Cardamon
committed
refactored rerouting status and broke array appending
Jill Cardamon
committed
refactor to have all logic for status banner management within StatusView.swift, added addNewStatus() and exposed it to NavigationViewController and TopBannerViewController
Jill Cardamon
committed
update integration test fixture
Jill Cardamon
committed
expose hideStatus(status:) to NavigationViewController and TopBannerViewController; hide enable precise location banner automatically
Jill Cardamon
committed
hiding enable precise location status is triggered automatically but doesn't get called in StatusView
Jill Cardamon
committed
issue with showing other statuses after one is hiddin is that there are multiple status views at play, and thus multiple statuses arrays
Jill Cardamon
committed
shows and hides multiple status banners properly; enable precise location banner automatically hides when precise location is enabled
Jill Cardamon
committed
need to add another way to hide to handle the case where things don't hide automatically
Jill Cardamon
committed
reflect added test file
Jill Cardamon
committed
change how status is hidden in manageStatuses()
Jill Cardamon
committed
add delay to hideStatus() call within manageStatuses(), change enable precise location banner back to infinite duration
Jill Cardamon
committed
changed name of authorizationChange boolean for clarity
Jill Cardamon
committed
deleted all calls/mentions of showStatus()
Jill Cardamon
committed
clean up code, add more test cases
Jill Cardamon
committed
test cases pass as expected
Jill Cardamon
committed
made test cases more resiliant; need to investigate using hideStatus() without dispatch
Jill Cardamon
committed
trying to use dispatch queue in hide
Jill Cardamon
committed
contained all delays within hide(), doesn't work
Jill Cardamon
committed
works with only one dispatch queue, need to rerun tests
Jill Cardamon
committed
deprecated old showStatus method, tests are better written and all but one assertion fails
Jill Cardamon
committed
updated test cases, wait for expectation fails but it's supposed to so it needs to be fixed
Jill Cardamon
committed
fixed failing test, removed debugging statements, clean up code
Jill Cardamon
committed
incorporating feedback
Jill Cardamon
committed
made priority public, added inline doc for addNewStatus()
Jill Cardamon
committed
update changelog, clean up code, add reducedAccuracyActivatedMode == false to navigationServiceDidChangeAuthorization so that halo view disappears when precise location is enabled so halo disappears
Jill Cardamon
committed
MapboxNavigationNative v31.0.1

1ec5
authored and
Jill Cardamon
committed
Add Changelog entry.

avi-c
authored and
Jill Cardamon
committed
Fix CHANGELOG entry to mention CarPlay

avi-c
authored and
Jill Cardamon
committed
Typo

1ec5
authored and
Jill Cardamon
committed
update changelog, clean up code, add reducedAccuracyActivatedMode == false to navigationServiceDidChangeAuthorization so that halo view disappears when precise location is enabled so halo disappears
Jill Cardamon
committed
incorporated feedback, update changelog
Jill Cardamon
committed
remove unnecessary doc comments from previous commit
Jill Cardamon
committed
fix changelog issue
Jill Cardamon
committed
fix status initialization in StatusViewTests
Jill Cardamon
committed

Commits on Mar 11, 2021

switch to typealias being priority instead of rawrepresentable
Jill Cardamon
committed
add doc comments, fix naming for priority value
Jill Cardamon
committed
clean up doc comments, remove Priority struct entirely
Jill Cardamon
committed