Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update new feature template to add user story requirement #2166

Merged
merged 2 commits into from
Feb 12, 2023

Conversation

ZeLonewolf
Copy link
Contributor

@ZeLonewolf ZeLonewolf commented Feb 11, 2023

User Story

As a developer I want to provide useful information to the maintainer team in order that I clearly describe the reason for desired code changes.

Motivation

In #2162 (comment), it was described that there's an undocumented expectation for issue authors to provide a user story which succinctly describes the purpose of the requested change. This PR formally adds that expectation explicitly in the issue template. This will assist authors of new feature tickets in better communicating what they are trying to accomplish.

Sorry for going straight to PR but I felt this was a simple enough change.

@HarelM
Copy link
Collaborator

HarelM commented Feb 11, 2023

This is a mixed PR? was it intentional?

@ZeLonewolf
Copy link
Contributor Author

Ugh no, I need to fix that

@ZeLonewolf ZeLonewolf force-pushed the zlw-user-story-template branch from 42558b0 to bf5eed1 Compare February 11, 2023 16:24
@ZeLonewolf
Copy link
Contributor Author

Fixed with clean commit history, sorry about that.

@HarelM
Copy link
Collaborator

HarelM commented Feb 11, 2023

No worries 😀
Thanks for putting up with me 😀

@HarelM
Copy link
Collaborator

HarelM commented Feb 11, 2023

Any chance to split this to two github buttons while you are at it? Bugs and features?

@ZeLonewolf
Copy link
Contributor Author

Any chance to split this to two github buttons while you are at it? Bugs and features?

In leading agile teams, I've always struggled with standard formats for reporting bugs. If you've been diligent in creating user stories for every feature (basically no team in the real world actually accomplishes this), then you can say "link the user story broken by this bug".

So I'm not sure if describing a bug in user story format is really the right concept. You already have expected behavior and actual behavior sections. Perhaps consider moving those two sections to the very top of the bug report would be better?

@HarelM
Copy link
Collaborator

HarelM commented Feb 11, 2023

I meant to say to create two different templates, one for bug and the other feature. Sorry if that wasn't clear.
I also think the current template is too long, and github now supports form filling, which I think is a far better user experience...

@ZeLonewolf
Copy link
Contributor Author

I meant to say to create two different templates, one for bug and the other feature. Sorry if that wasn't clear. I also think the current template is too long, and github now supports form filling, which I think is a far better user experience...

There are already separate templates for bugs and features:
https://github.com/maplibre/maplibre-gl-js/tree/main/.github/ISSUE_TEMPLATE

This PR was specifically addressing a deficiency in the new feature template. However, if I were to simplify the new feature template, it might look something like:

  • User story
    • Just the one sentence user story
  • Rationale
    • Why is this feature needed / use cases
    • What workarounds / alternatives exist?
  • Impact
    • How are end-users impacted if this is not implemented?

The other sections of the new feature template seem more appropriate to an implementation/PR discussion

@HarelM
Copy link
Collaborator

HarelM commented Feb 11, 2023

This sounds better than the current complicated template, feel free to change it.

@ZeLonewolf
Copy link
Contributor Author

Updated template as discussed.

-->

## Design
As a <role> I can <capability>, so that <receive benefit>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't these "<" disappear due to markdown stuff?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's all within the <!-- --> HTML comment blocks so everything within will disappear if not edited.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right...

@HarelM HarelM merged commit 0a617e4 into maplibre:main Feb 12, 2023
@ZeLonewolf ZeLonewolf deleted the zlw-user-story-template branch February 12, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants