Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/update cluster changes #189

Merged
merged 6 commits into from
Aug 26, 2024
Merged

Fix/update cluster changes #189

merged 6 commits into from
Aug 26, 2024

Conversation

marcjulian
Copy link
Collaborator

@marcjulian marcjulian commented Aug 22, 2024

Fixes #188

@marcjulian marcjulian requested a review from HarelM August 22, 2024 18:25
@marcjulian marcjulian requested a review from HarelM August 23, 2024 11:35
@HarelM
Copy link
Collaborator

HarelM commented Aug 23, 2024

I've noticed that the cluster code keeps refreshing even if nothing changes (I've added a console.log in updateCluster method in MarkersForClustersComponent) do you think it's the right behavior?

@marcjulian
Copy link
Collaborator Author

I've noticed that the cluster code keeps refreshing even if nothing changes (I've added a console.log in updateCluster method in MarkersForClustersComponent) do you think it's the right behavior?

I added the same log in updateCluster before #178 was merged. The function is only triggered once at the beginning and when zoomed. I guess its not right that it keeps calling this function after #178 without any interaction.

@HarelM
Copy link
Collaborator

HarelM commented Aug 23, 2024

Yup...

@HarelM
Copy link
Collaborator

HarelM commented Aug 23, 2024

I wonder if there are other places where this happens.
Cc: @n-elhk.

@marcjulian
Copy link
Collaborator Author

@HarelM I'm using now afterRender to call applyChanges instead of zone.onMicrotaskEmpty. I also renamed applyChanges to clearMapElements, what do you think about the name?

I think the case where updateCluster is being called multiple times is unrelated with this issue, perhaps we should open a new issue and pr for that.

Copy link
Collaborator

@HarelM HarelM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@HarelM
Copy link
Collaborator

HarelM commented Aug 26, 2024

Feel free to open a different issue, whatever work for you, I'm good with it.
I would simply like to make sure we solve this as this is a performance issue from my point of view.

@marcjulian marcjulian merged commit 921a598 into main Aug 26, 2024
2 checks passed
@marcjulian marcjulian deleted the fix/update-cluster-changes branch August 26, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTML clusters are not working correct
2 participants