Making the ES module #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrsloup
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Looks good 👍
About the versioning/CDN -- are there actually any breaking changes?
I think we can still ship this as v2 even though it could maybe technically be just a minor version update.
But I'm thinking more about the CDN and latest placeholder -- is it safe to the the update in place? (As previously discussed, I don't like the latest and we should maybe gradually stop recommending people to use that. Even v1 symlink to the latest v1.x.x would be better.)
|
No breaking changes so it should be safe to update in place. And i agree that v1, v2, v3 is better than latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RD-175
This PR is about revamping the library so that it can be installed from NPM and used as an ES module. The effort was made to keep it backward compatible with the pure CDN version.
The vector layer helpers from the SDK are also now exposed directly from the custom MapTiler SDK Map Leaflet layer.