Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add showFilterWithList option #137

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fremail
Copy link

@fremail fremail commented Jun 20, 2023

Added a new option. When it's true, it adds 2 differences to the lib work:

  1. It puts a filter input outside of the header block (then clicking on that field doesn't close the dropdown)
  2. The filter is shown only when the dropdown is expanded.

These changes allow to show the filter when the dropdown is expanded, so filtering is enabled for mobile device users (a keyboard is swon when an input is focused, but if there's no input visible, then no way to put a focus and trigger the keyboard).

P.S. I have no idea why I have updated files in ./js/lib/* dir in this PR and not in another. I ran both npm run dev and npm run prod on both branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant