Adjust combined error implementation (fix InsightRX#33)

marianklose · Dec 22, 2023 · 83bc70b · 83bc70b
1 parent c722355
commit 83bc70b
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/R/parse_model_definitions.R b/R/parse_model_definitions.R
@@ -200,7 +200,7 @@ parse_model_definitions <- function(
     "if(ltbs_", obs_types, ") {", cr, "  ",
     "  log_dv_", obs_types, " ~ normal(log(ipred_obs_", obs_types, "), ruv_add_", obs_types, "); ", cr, "  ",
     "} else {", cr, "  ",
-    "  dv_", obs_types, " ~ normal(ipred_obs_", obs_types, ", (ruv_prop_", obs_types, " * ipred_obs_", obs_types, " + ruv_add_", obs_types,"));", cr, "  ",
+    "  dv_", obs_types, " ~ normal(ipred_obs_", obs_types, ", (sqrt(pow(ruv_prop_", obs_types, " * ipred_obs_", obs_types, ", 2) + pow(ruv_add_", obs_types,", 2)));", cr, "  ",
     "}"
   )
 
@@ -214,7 +214,7 @@ parse_model_definitions <- function(
     paste0("real ipred_ruv_", obs_types, "[n_obs_", obs_types, "];"),
     paste0(
        "for(i in 1:n_obs_", obs_types, "){", cr, "  ",
-       "  ipred_ruv_", obs_types, "[i] = normal_rng(ipred_obs_", obs_types, "[i], (ruv_prop_", obs_types, " * ipred_obs_", obs_types, "[i] + ruv_add_", obs_types, "));", cr, "  ",
+       "  ipred_ruv_", obs_types, "[i] = normal_rng(ipred_obs_", obs_types, "[i], (sqrt(pow(ruv_prop_", obs_types, " * ipred_obs_", obs_types, "[i], 2) + pow(ruv_add_", obs_types, ", 2)));", cr, "  ",
        "}"
     ) 
   )