Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deku-c-toolkit] Use bigint instead of number #988

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[deku-c-toolkit] Use bigint instead of number #988

wants to merge 1 commit into from

Conversation

Gau-thier
Copy link
Contributor

@Gau-thier Gau-thier commented Nov 21, 2022 •
edited
Loading

Problem

Using number in javascript to represent Int from WASM VM can lead to manipulate some infinity values...

Solution

Toolkig v0.1.5

Use bigint in the deku-c-toolkit instead of number

Tests

  • tested locally with decookies ✅

@Gau-thier Gau-thier requested a review from Pilou97 November 21, 2022 13:56
@Gau-thier Gau-thier force-pushed the toolkit/switchToBigInt branch from 0bb5887 to 9896978 Compare November 21, 2022 14:52
@Gau-thier Gau-thier mentioned this pull request Nov 21, 2022
Open
@Gau-thier Gau-thier marked this pull request as ready for review November 21, 2022 17:22
@Gau-thier Gau-thier changed the title WIP use bigint instead of number Use bigint instead of number Nov 21, 2022
@Gau-thier Gau-thier changed the title Use bigint instead of number [deku-c-toolkit] Use bigint instead of number Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pilou97 Pilou97 Awaiting requested review from Pilou97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Gau-thier