Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(avatar): Avatar deletion is now persisted as expected #57

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Fix(avatar): Avatar deletion is now persisted as expected #57

merged 1 commit into from
Aug 12, 2024

Conversation

jonathanarnault
Copy link
Collaborator

Problem

Avatar deletion is not persisted

Solution

Use null instead of undefined when reseting form and submit on deletion

How To Test

Add an avatar to profile, remove it and refresh the page

Additional Checks

@jonathanarnault jonathanarnault merged commit 1dbc5e7 into main Aug 12, 2024
5 checks passed
@jonathanarnault jonathanarnault deleted the fix/delete-avatar branch August 12, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arimet arimet arimet approved these changes

Assignees
No one assigned
Labels
RFR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathanarnault @arimet