lua: complete-filename: use biggest possible prefix #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for example to complete file names in markdown images. E.g.: 
rnpnr
force-pushed
the
complete_filename_increase_prefix
branch
from
d13a800 to
4d5bfb8
Compare
|
Looked fine to me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for example to complete file names in markdown images.
E.g.:
![](pic<C-x><C-f>will complete the file name starting with pic.Previously it would have detected the
'['as prefix and looked for files starting with](pic.Maybe I can sneek this in before #1185. This is sitting on top of my tree for quite some time now and I have not encountered any regression using the biggest possible match with our regex.
Apparently, my email setup is currently broken hence the github pull request.