-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connections between Size, Truncation and Connectedness #333
Connections between Size, Truncation and Connectedness #333
Conversation
@martinescardo if you'd like to take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I request minor changes only. Thanks for formalizing this.
It would be nice to formalize the join construction in a future pull request. :-)
Thanks @martinescardo! I would still like @tomdjong to take a look when he gets a chance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also only had minor comments. Thanks @IanRay11!
Another small comment: could you rename the file from |
Also, could you please record the following corollary/example of Theorem 2.6: the set truncation of the universe is large (i.e. cannot be small). Thanks! |
In fact, this was the initial motivation for asking somebody on mathstodon to formalize Dan's result, and you volunteered. |
…ning helper function names with TypeTopology convention.
Right... sorry. It's been awhile and I lost track. |
@tomdjong ready for further review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more minor comments.
Okay, hopefully the comment before Thm 2.6. is better now. @tomdjong |
@martinescardo Do you wish to take one last look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, @IanRay11 .
Done. I am happy for you to merge whenever you are ready. |
I am now pushing the file on on Size, Truncation and Connectedness that was split off from the original PR. One of the main things I need to revisit here are the naming schemes; both of the results from Dan's paper and in my where blocks. I spent some time thinking about renaming results other than Prop-2-2 (for example) but describing the result is typically a mouth full so I wanted to get some feedback. @tomdjong.
By the way I checked for unused imports (by hand lol) and I referenced Dan's paper correctly (these where things suggested in the original PR before the split).