Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connections between Size, Truncation and Connectedness #333

Merged

Conversation

IanRay11
Copy link
Contributor

@IanRay11 IanRay11 commented Jan 8, 2025

I am now pushing the file on on Size, Truncation and Connectedness that was split off from the original PR. One of the main things I need to revisit here are the naming schemes; both of the results from Dan's paper and in my where blocks. I spent some time thinking about renaming results other than Prop-2-2 (for example) but describing the result is typically a mouth full so I wanted to get some feedback. @tomdjong.

By the way I checked for unused imports (by hand lol) and I referenced Dan's paper correctly (these where things suggested in the original PR before the split).

@IanRay11
Copy link
Contributor Author

IanRay11 commented Jan 8, 2025

@martinescardo if you'd like to take a look.

Copy link
Owner

@martinescardo martinescardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I request minor changes only. Thanks for formalizing this.

It would be nice to formalize the join construction in a future pull request. :-)

source/UF/SizeTruncationandConnectedness.lagda Outdated Show resolved Hide resolved
source/UF/SizeTruncationandConnectedness.lagda Outdated Show resolved Hide resolved
source/UF/SizeTruncationandConnectedness.lagda Outdated Show resolved Hide resolved
source/UF/SizeTruncationandConnectedness.lagda Outdated Show resolved Hide resolved
source/UF/SizeTruncationandConnectedness.lagda Outdated Show resolved Hide resolved
source/UF/SizeTruncationandConnectedness.lagda Outdated Show resolved Hide resolved
source/UF/SizeTruncationandConnectedness.lagda Outdated Show resolved Hide resolved
source/UF/SizeTruncationandConnectedness.lagda Outdated Show resolved Hide resolved
source/UF/SizeTruncationandConnectedness.lagda Outdated Show resolved Hide resolved
source/UF/SizeTruncationandConnectedness.lagda Outdated Show resolved Hide resolved
@IanRay11
Copy link
Contributor Author

IanRay11 commented Jan 9, 2025

Thanks @martinescardo! I would still like @tomdjong to take a look when he gets a chance.

Copy link
Collaborator

@tomdjong tomdjong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also only had minor comments. Thanks @IanRay11!

source/UF/SizeTruncationandConnectedness.lagda Outdated Show resolved Hide resolved
source/UF/SizeTruncationandConnectedness.lagda Outdated Show resolved Hide resolved
source/UF/SizeTruncationandConnectedness.lagda Outdated Show resolved Hide resolved
source/UF/SizeTruncationandConnectedness.lagda Outdated Show resolved Hide resolved
source/UF/SizeTruncationandConnectedness.lagda Outdated Show resolved Hide resolved
@tomdjong
Copy link
Collaborator

tomdjong commented Jan 9, 2025

Another small comment: could you rename the file from SizeTruncationandConnectedness.lagda to Size-TruncatedConnected.lagda?

@tomdjong
Copy link
Collaborator

tomdjong commented Jan 9, 2025

Also, could you please record the following corollary/example of Theorem 2.6: the set truncation of the universe is large (i.e. cannot be small). Thanks!

@martinescardo
Copy link
Owner

Also, could you please record the following corollary/example of Theorem 2.6: the set truncation of the universe is large (i.e. cannot be small). Thanks!

In fact, this was the initial motivation for asking somebody on mathstodon to formalize Dan's result, and you volunteered.

@IanRay11
Copy link
Contributor Author

Also, could you please record the following corollary/example of Theorem 2.6: the set truncation of the universe is large (i.e. cannot be small). Thanks!

In fact, this was the initial motivation for asking somebody on mathstodon to formalize Dan's result, and you volunteered.

Right... sorry. It's been awhile and I lost track.

@IanRay11
Copy link
Contributor Author

@tomdjong ready for further review

Copy link
Collaborator

@tomdjong tomdjong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more minor comments.

source/UF/Size-TruncatedConnected.lagda Outdated Show resolved Hide resolved
source/UF/Size-TruncatedConnected.lagda Outdated Show resolved Hide resolved
source/UF/Size-TruncatedConnected.lagda Outdated Show resolved Hide resolved
source/UF/Size-TruncatedConnected.lagda Outdated Show resolved Hide resolved
source/UF/Size-TruncatedConnected.lagda Outdated Show resolved Hide resolved
@IanRay11
Copy link
Contributor Author

Okay, hopefully the comment before Thm 2.6. is better now. @tomdjong

source/UF/Size-TruncatedConnected.lagda Outdated Show resolved Hide resolved
source/UF/Size-TruncatedConnected.lagda Outdated Show resolved Hide resolved
@tomdjong
Copy link
Collaborator

@martinescardo Do you wish to take one last look?

Copy link
Owner

@martinescardo martinescardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @IanRay11 .

source/UF/Size-TruncatedConnected.lagda Outdated Show resolved Hide resolved
source/UF/Size-TruncatedConnected.lagda Outdated Show resolved Hide resolved
@martinescardo
Copy link
Owner

@martinescardo Do you wish to take one last look?

Done. I am happy for you to merge whenever you are ready.

@tomdjong tomdjong merged commit 8bb8f1a into martinescardo:master Jan 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants