Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the gitui to 0.26.3 #7261

Merged
merged 4 commits into from
Nov 1, 2024
Merged

Conversation

adamma1024
Copy link
Contributor

Describe your changes

I've created an issue recently, but I found it's gitui's fault. Their 0.26.2 doesn't work on darwin_x64. #7260

I noticed the upgrading of gitui was failed #5956 , so I upgraded the gitui to 0.26.3 and solved this issue.

Issue ticket number and link

#7260
#5956

Checklist before requesting a review

  • I have successfully tested installation of the package.
  • I have successfully tested the package after installation.

Screenshots

image image image

@williambotman williambotman requested a review from a team September 18, 2024 22:31
@adamma1024
Copy link
Contributor Author

adamma1024 commented Sep 18, 2024

Hi @williamboman , I'm not sure if it's enough. Let me know if I still need to do something. I'm glad to contribute such a meaningful project with you all.

@adamma1024
Copy link
Contributor Author

Hi, is there anyone can help review? Appreciate so much.

@adamma1024
Copy link
Contributor Author

bump

@Conarius
Copy link
Contributor

I would rebase your fork and then merge it into main instead of that renovate branch, so you don't repeat all the previous commits and that after the merge it's in main so everybody has it.

@adamma1024
Copy link
Contributor Author

I would rebase your fork and then merge it into main instead of that renovate branch, so you don't repeat all the previous commits and that after the merge it's in main so everybody has it.

No problem. Thank you.

* origin/main: (451 commits)
  bump(ktfmt): v0.53 (mason-org#7744)
  bump(sorbet): update to v0.5.11631 (mason-org#7758)
  bump(markdown-oxide): update to v0.24.3 (mason-org#7757)
  bump(semgrep): update to v1.95.0 (mason-org#7756)
  bump(opa): update to v0.70.0 (mason-org#7754)
  bump(visualforce-language-server): update to v62.3.1 (mason-org#7755)
  bump(apex-language-server): update to v62.3.1 (mason-org#7753)
  bump(ruby-lsp): update to v0.21.1 (mason-org#7752)
  bump(ruby-lsp): update to v0.21.0 (mason-org#7750)
  bump(dart-debug-adapter): update to v3.100.0 (mason-org#7749)
  bump(trufflehog): update to v3.83.2 (mason-org#7748)
  bump(markuplint): update to v4.11.2 (mason-org#7746)
  bump(rubocop): update to v1.68.0 (mason-org#7745)
  bump(sorbet): update to v0.5.11630 (mason-org#7722)
  bump(semgrep): update to v1.94.0 (mason-org#7743)
  bump(powershell-editor-services): update to v3.21.0 (mason-org#7742)
  bump(trufflehog): update to v3.83.1 (mason-org#7741)
  bump(cfn-lint): update to v1.18.3 (mason-org#7738)
  bump(vue-language-server): update to v2.1.10 (mason-org#7740)
  bump(eslint_d): update to v14.2.2 (mason-org#7739)
  ...
@williamboman williamboman changed the base branch from renovate/gitui-0.x to main November 1, 2024 10:58
Copy link
Member

@williamboman williamboman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I updated the merge base and fixed the version overrides (we need 2 of them to support versions >0.25.2 <=0.26.2)

@williamboman williamboman merged commit 5268d90 into mason-org:main Nov 1, 2024
18 checks passed
TungstnBallon pushed a commit to TungstnBallon/mason-registry that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants