Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #2620

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ratseburzhynskyi
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the makeCalculator function! 🎉 Your code meets the task requirements and constraints effectively. The operate method is flexible and allows any function to be passed as a callback, which aligns perfectly with the task's expectations. Keep up the excellent work, and happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +17 to +18
operate(callback, number) {
this.result = callback(this.result, number);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The operate method should not restrict the callback to only the calculator's own methods. According to the task requirements, any function can be passed as a callback, and it's expected. You can check if the callback is a function using typeof callback === 'function'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants