Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

first try #104

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

first try #104

wants to merge 3 commits into from

Conversation

Nikolaymelni
Copy link

@Nikolaymelni Nikolaymelni commented Feb 27, 2023 •
edited
Loading

polosanya
polosanya suggested changes Mar 1, 2023
View reviewed changes
Copy link

@polosanya polosanya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The links navigate to the HTML Form task.
I guess you added the wrong links to your PR description. Please fix it)
image

src/index.html Outdated
Comment on lines 69 to 71
</nav>

</header>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</nav>
</header>
</nav>
</header>

Don't leave empty lines between parent and child elements

src/style.css Outdated
Comment on lines 1 to 5
* {
margin: 0;
font-family: "Roboto", sans-serif;
font-weight: 500;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Better specify the exact tags you want to change. Also, you can set the font-family for the whole page and inherit where needed

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Links changed, copied them from the old task by accident)

@Nikolaymelni Nikolaymelni reopened this Mar 1, 2023
@Nikolaymelni Nikolaymelni requested a review from polosanya March 1, 2023 18:15
qoa11a
qoa11a suggested changes Mar 2, 2023
View reviewed changes
Copy link

@qoa11a qoa11a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to pass the tests. Looks like your content is positioned higher than it should be. Check margins and height of underline for active link.
image

@Nikolaymelni
Copy link
Author

Nikolaymelni commented Mar 2, 2023 •
edited
Loading

Hello! I changed paddings for links from 22 to 23 px. It helped to solve 50% of tests. But I don`t understand how to pass the entire test.
image

@Nikolaymelni Nikolaymelni requested review from qoa11a and removed request for polosanya March 2, 2023 13:14
qoa11a
qoa11a approved these changes Mar 2, 2023
View reviewed changes
Copy link

@qoa11a qoa11a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Don't mind tests, everything looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polosanya polosanya polosanya requested changes

@qoa11a qoa11a qoa11a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nikolaymelni @polosanya @qoa11a