Solution #108
Solution #108
Conversation
ArtemVelychko
commented
Apr 28, 2023
ArtemVelychko
commented
- DEMO LINK
- TEST REPORT LINK
| > | ||
|
|
||
| </head> |
There was a problem hiding this comment.
| > | |
| </head> | |
| > | |
| </head> |
src/index.html
Outdated
| </a> | ||
| <nav class="nav"> |
There was a problem hiding this comment.
Don't forget to add empty lines between multiline sibling blocks of HTML. Check it everywhere, please
| </a> | |
| <nav class="nav"> | |
| </a> | |
| <nav class="nav"> |
src/style.css
Outdated
| @@ -1 +1,71 @@ | |||
| /* Styles go here */ | |||
There was a problem hiding this comment.
remove redundant comments
src/style.css
Outdated
| align-items: center; | ||
| justify-content: space-between; | ||
| padding: 0 50px; | ||
| background-color: #fff; |
There was a problem hiding this comment.
Isn't it white by default?
| background-color: #fff; |
src/style.css
Outdated
| .nav__list { | ||
| margin: 0; | ||
| padding: 0; | ||
| position: relative; |
There was a problem hiding this comment.
Do you really need a relative position here?
src/style.css
Outdated
|
|
||
| .nav__link { | ||
| display: block; | ||
| position: relative; |
src/style.css
Outdated
| } | ||
|
|
||
| .is-active { | ||
| color: #00acdc; |
There was a problem hiding this comment.
Use variables for repeatable colors
src/index.html
Outdated
| <link | ||
| rel="preconnect" | ||
| href="https://fonts.gstatic.com" | ||
| > |
There was a problem hiding this comment.
You don't really need to wrap the line if there are only 2 attributes. But it's up to you actually
src/index.html
Outdated
| <link | ||
| href="https://fonts.googleapis.com/css2?family=Roboto:wght@500&display=swap" rel="stylesheet" | ||
| > |
There was a problem hiding this comment.
In this case this syntax will look better
| <link | |
| href="https://fonts.googleapis.com/css2?family=Roboto:wght@500&display=swap" rel="stylesheet" | |
| > | |
| <link | |
| href="https://fonts.googleapis.com/css2?family=Roboto:wght@500&display=swap" | |
| rel="stylesheet" | |
| > |
| :root { | ||
| --blue: #00acdc; | ||
| } |
There was a problem hiding this comment.
Basically, it's better to create a separate file for variables
