Moyo Header #115
Moyo Header #115
Conversation
usernameluke
commented
Jul 25, 2023
usernameluke
commented
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
- Do you really need all these fonts? You use only the medium one. You can use google fonts instead, by the way
src/index.html
Outdated
| href="#laptops"> | ||
| Laptops & computers |
There was a problem hiding this comment.
| href="#laptops"> | |
| Laptops & computers | |
| href="#laptops" | |
| > | |
| Laptops & computers |
src/index.html
Outdated
| </a> | ||
| </li> | ||
|
|
||
| <li class="item" > |
There was a problem hiding this comment.
| <li class="item" > | |
| <li class="item"> |
src/style.css
Outdated
| padding: 0; | ||
| } | ||
|
|
||
| header { |
There was a problem hiding this comment.
Hey, I know this is gonna sound stupid, but I'm struggling to figure out which class to assign these to... Could you point me in the right direction? Cheers
There was a problem hiding this comment.
Actually, I think I've figured it out. Sorry!
src/style.css
Outdated
| padding: 0; | ||
| } | ||
|
|
||
| .item + .item { |
There was a problem hiding this comment.
Don't increase selectors' specificity unless completely necessary. You can use nth-child instead
src/style.css
Outdated
| } | ||
|
|
||
| .logo { | ||
| padding-top: 2px; |
There was a problem hiding this comment.
Seems that it's redundant. Just align the logo to the center
There was a problem hiding this comment.
Hi!
Check all unresolved comments here https://github.com/mate-academy/layout_moyo-header-en/pull/115/files.
Make fixes, commit, push, and then request review again.
If you have any questions, feel free to ask them in Slack.
src/style.css
Outdated
| padding: 0; | ||
| } | ||
|
|
||
| header { |
There was a problem hiding this comment.
Hey, I know this is gonna sound stupid, but I'm struggling to figure out which class to assign these to... Could you point me in the right direction? Cheers
src/style.css
Outdated
| padding: 0; | ||
| } | ||
|
|
||
| header { |
There was a problem hiding this comment.
Actually, I think I've figured it out. Sorry!
