Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #5445

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add task solution #5445

wants to merge 2 commits into from

Conversation

RomanPlyta
Copy link

  • DEMO LINK

  • TEST REPORT LINK

  • Yellow stars are added with container modifier + pseudo-selector (NO extra classes)

  • Each BEM block has its own separate file

  • All Typical Mistakes from BEM lesson theory are checked.

  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your implementation is almost there! However, there are a few critical issues that need to be addressed before we can approve your work. Specifically, the use of extra classes like stars__star--active goes against the task requirements, which specify handling the active state with container modifiers and pseudo-selectors. Additionally, the BEM structure should be organized with each block in its own file. Once these issues are resolved, your code will be in great shape! Keep up the good work, and I'm confident you'll nail it with these adjustments! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the task requirements! 🎉 Your use of the BEM methodology is spot on, and you've effectively handled the active state of the stars using container modifiers and pseudo-selectors. The HTML and CSS structures are well-organized, and you've successfully addressed previous issues.

While there are no critical issues, always ensure that your CSS file reflects the active state visually as intended. Keep up the good work, and remember to review the comments to further refine your skills. This decision is made to help you move forward with your learning journey. Keep improving and learning from your experiences! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants