-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #5448
base: master
Are you sure you want to change the base?
add task solution #5448
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work on this! 😊 However, there are a few critical issues that need to be addressed before we can proceed. The use of the stars__star__active
class for active stars violates the requirement to use a container modifier and a pseudo-selector. Additionally, the CSS should not rely on extra classes for styling active stars. Please also ensure compliance with BEM methodology by separating each block into its own file and check that lines do not exceed 80 characters. Once these are resolved, your implementation will be in great shape! Keep up the great work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: 7]
If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your submission has been approved to help you move forward with your learning journey. However, there are some important issues to address. The use of the stars__star--active
class does not meet the task requirements for using a container modifier and a pseudo-selector for styling active stars. Please consider using a pseudo-selector like :nth-child
on the container for this purpose. This will ensure compliance with the task requirements and improve your code's adherence to BEM methodology. Keep up the good work, and make sure to address these points in future projects to enhance your skills! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
src/index.html
Outdated
<div class="stars__star"></div> | ||
</div> | ||
<div class="stars stars--1"> | ||
<div class="stars__star stars__star--active"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of the stars__star--active
class violates the requirement to use a container modifier and a pseudo-selector for styling active stars. Consider using a pseudo-selector like :nth-child
on the container to style active stars.
src/index.html
Outdated
<div class="stars__star"></div> | ||
</div> | ||
<div class="stars stars--2"> | ||
<div class="stars__star stars__star--active"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of the stars__star--active
class violates the requirement to use a container modifier and a pseudo-selector for styling active stars. Consider using a pseudo-selector like :nth-child
on the container to style active stars.
src/index.html
Outdated
</div> | ||
<div class="stars stars--2"> | ||
<div class="stars__star stars__star--active"></div> | ||
<div class="stars__star stars__star--active"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of the stars__star--active
class violates the requirement to use a container modifier and a pseudo-selector for styling active stars. Consider using a pseudo-selector like :nth-child
on the container to style active stars.
src/index.html
Outdated
<div class="stars__star"></div> | ||
</div> | ||
<div class="stars stars--3"> | ||
<div class="stars__star stars__star--active"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of the stars__star--active
class violates the requirement to use a container modifier and a pseudo-selector for styling active stars. Consider using a pseudo-selector like :nth-child
on the container to style active stars.
src/index.html
Outdated
</div> | ||
<div class="stars stars--3"> | ||
<div class="stars__star stars__star--active"></div> | ||
<div class="stars__star stars__star--active"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of the stars__star--active
class violates the requirement to use a container modifier and a pseudo-selector for styling active stars. Consider using a pseudo-selector like :nth-child
on the container to style active stars.
src/index.html
Outdated
</div> | ||
<div class="stars stars--5"> | ||
<div class="stars__star stars__star--active"></div> | ||
<div class="stars__star stars__star--active"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of the stars__star--active
class violates the requirement to use a container modifier and a pseudo-selector for styling active stars. Consider using a pseudo-selector like :nth-child
on the container to style active stars.
src/index.html
Outdated
<div class="stars stars--5"> | ||
<div class="stars__star stars__star--active"></div> | ||
<div class="stars__star stars__star--active"></div> | ||
<div class="stars__star stars__star--active"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of the stars__star--active
class violates the requirement to use a container modifier and a pseudo-selector for styling active stars. Consider using a pseudo-selector like :nth-child
on the container to style active stars.
src/index.html
Outdated
<div class="stars__star stars__star--active"></div> | ||
<div class="stars__star stars__star--active"></div> | ||
<div class="stars__star stars__star--active"></div> | ||
<div class="stars__star stars__star--active"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of the stars__star--active
class violates the requirement to use a container modifier and a pseudo-selector for styling active stars. Consider using a pseudo-selector like :nth-child
on the container to style active stars.
src/index.html
Outdated
<div class="stars__star stars__star--active"></div> | ||
<div class="stars__star stars__star--active"></div> | ||
<div class="stars__star stars__star--active"></div> | ||
<div class="stars__star stars__star--active"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of the stars__star--active
class violates the requirement to use a container modifier and a pseudo-selector for styling active stars. Consider using a pseudo-selector like :nth-child
on the container to style active stars.
src/style.css
Outdated
.stars__star--active { | ||
background-image: url(images/star-active.svg); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of the stars__star--active
class violates the requirement to use a container modifier and a pseudo-selector for styling active stars. You should use a pseudo-selector like :nth-child
on the .stars
container to apply the active star styling, rather than relying on an extra class.
❗️ Copy this
Checklist
to thePull Request
description after links, and put- [x]
before each point after you checked it.Typical Mistakes
fromBEM
lesson theory are checked.