Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #5448

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add task solution #5448

wants to merge 3 commits into from

Conversation

yuammik
Copy link

@yuammik yuammik commented Feb 28, 2025

❗️ Copy this Checklist to the Pull Request description after links, and put - [x] before each point after you checked it.

  • Yellow stars are added with container modifier + pseudo-selector (NO extra classes)
  • Each BEM block has its own separate file
  • All Typical Mistakes from BEM lesson theory are checked.
  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work on this! 😊 However, there are a few critical issues that need to be addressed before we can proceed. The use of the stars__star__active class for active stars violates the requirement to use a container modifier and a pseudo-selector. Additionally, the CSS should not rely on extra classes for styling active stars. Please also ensure compliance with BEM methodology by separating each block into its own file and check that lines do not exceed 80 characters. Once these are resolved, your implementation will be in great shape! Keep up the great work! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: 7]

If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.

@yuammik yuammik marked this pull request as draft February 28, 2025 14:37
@yuammik yuammik marked this pull request as ready for review February 28, 2025 14:38
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your submission has been approved to help you move forward with your learning journey. However, there are some important issues to address. The use of the stars__star--active class does not meet the task requirements for using a container modifier and a pseudo-selector for styling active stars. Please consider using a pseudo-selector like :nth-child on the container for this purpose. This will ensure compliance with the task requirements and improve your code's adherence to BEM methodology. Keep up the good work, and make sure to address these points in future projects to enhance your skills! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

src/index.html Outdated
<div class="stars__star"></div>
</div>
<div class="stars stars--1">
<div class="stars__star stars__star--active"></div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of the stars__star--active class violates the requirement to use a container modifier and a pseudo-selector for styling active stars. Consider using a pseudo-selector like :nth-child on the container to style active stars.

src/index.html Outdated
<div class="stars__star"></div>
</div>
<div class="stars stars--2">
<div class="stars__star stars__star--active"></div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of the stars__star--active class violates the requirement to use a container modifier and a pseudo-selector for styling active stars. Consider using a pseudo-selector like :nth-child on the container to style active stars.

src/index.html Outdated
</div>
<div class="stars stars--2">
<div class="stars__star stars__star--active"></div>
<div class="stars__star stars__star--active"></div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of the stars__star--active class violates the requirement to use a container modifier and a pseudo-selector for styling active stars. Consider using a pseudo-selector like :nth-child on the container to style active stars.

src/index.html Outdated
<div class="stars__star"></div>
</div>
<div class="stars stars--3">
<div class="stars__star stars__star--active"></div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of the stars__star--active class violates the requirement to use a container modifier and a pseudo-selector for styling active stars. Consider using a pseudo-selector like :nth-child on the container to style active stars.

src/index.html Outdated
</div>
<div class="stars stars--3">
<div class="stars__star stars__star--active"></div>
<div class="stars__star stars__star--active"></div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of the stars__star--active class violates the requirement to use a container modifier and a pseudo-selector for styling active stars. Consider using a pseudo-selector like :nth-child on the container to style active stars.

src/index.html Outdated
</div>
<div class="stars stars--5">
<div class="stars__star stars__star--active"></div>
<div class="stars__star stars__star--active"></div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of the stars__star--active class violates the requirement to use a container modifier and a pseudo-selector for styling active stars. Consider using a pseudo-selector like :nth-child on the container to style active stars.

src/index.html Outdated
<div class="stars stars--5">
<div class="stars__star stars__star--active"></div>
<div class="stars__star stars__star--active"></div>
<div class="stars__star stars__star--active"></div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of the stars__star--active class violates the requirement to use a container modifier and a pseudo-selector for styling active stars. Consider using a pseudo-selector like :nth-child on the container to style active stars.

src/index.html Outdated
<div class="stars__star stars__star--active"></div>
<div class="stars__star stars__star--active"></div>
<div class="stars__star stars__star--active"></div>
<div class="stars__star stars__star--active"></div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of the stars__star--active class violates the requirement to use a container modifier and a pseudo-selector for styling active stars. Consider using a pseudo-selector like :nth-child on the container to style active stars.

src/index.html Outdated
<div class="stars__star stars__star--active"></div>
<div class="stars__star stars__star--active"></div>
<div class="stars__star stars__star--active"></div>
<div class="stars__star stars__star--active"></div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of the stars__star--active class violates the requirement to use a container modifier and a pseudo-selector for styling active stars. Consider using a pseudo-selector like :nth-child on the container to style active stars.

src/style.css Outdated
Comment on lines 18 to 20
.stars__star--active {
background-image: url(images/star-active.svg);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of the stars__star--active class violates the requirement to use a container modifier and a pseudo-selector for styling active stars. You should use a pseudo-selector like :nth-child on the .stars container to apply the active star styling, rather than relying on an extra class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants