Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task solution #5455

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add task solution #5455

wants to merge 1 commit into from

Conversation

Vanivnaa
Copy link

@Vanivnaa Vanivnaa commented Mar 2, 2025

  • DEMO LINK

  • TEST REPORT LINK

  • Yellow stars are added with container modifier + pseudo-selector (NO extra classes)

  • Each BEM block has its own separate file

  • All Typical Mistakes from BEM lesson theory are checked.

  • Code follows all the Code Style Rules ❗️

mateacademy-ai-mentor
mateacademy-ai-mentor approved these changes Mar 2, 2025
View reviewed changes
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the star rating system! 🌟 The code meets most of the task requirements, and the functionality is intact. While there are minor issues like the use of object-fit on background images and some BEM compliance points, these do not impact the core functionality. Keep up the good work and consider the feedback for future improvements!

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

src/style.css
.stars--0 .stars_star {
background-image: url(../src/images/star.svg);
background-repeat: no-repeat;
object-fit: contain;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The object-fit: contain; property is not applicable to background images. It is used for replaced elements like <img>. Consider removing this line.

src/style.css
.stars--1 .stars_star:nth-child(-n + 1) {
background-image: url(../src/images/star-active.svg);
background-repeat: no-repeat;
object-fit: contain;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The object-fit: contain; property is not applicable to background images. It is used for replaced elements like <img>. Consider removing this line.

src/style.css
.stars--1 .stars_star:nth-child(n + 2) {
background-image: url(../src/images/star.svg);
background-repeat: no-repeat;
object-fit: contain;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The object-fit: contain; property is not applicable to background images. It is used for replaced elements like <img>. Consider removing this line.

src/style.css
.stars--2 .stars_star:nth-child(-n + 2) {
background-image: url(../src/images/star-active.svg);
background-repeat: no-repeat;
object-fit: contain;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The object-fit: contain; property is not applicable to background images. It is used for replaced elements like <img>. Consider removing this line.

src/style.css
.stars--2 .stars_star:nth-child(n + 3) {
background-image: url(../src/images/star.svg);
background-repeat: no-repeat;
object-fit: contain;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The object-fit: contain; property is not applicable to background images. It is used for replaced elements like <img>. Consider removing this line.

src/style.css
.stars--3 .stars_star:nth-child(-n + 3) {
background-image: url(../src/images/star-active.svg);
background-repeat: no-repeat;
object-fit: contain;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The object-fit: contain; property is not applicable to background images. It is used for replaced elements like <img>. Consider removing this line.

src/style.css
.stars--3 .stars_star:nth-child(n + 4) {
background-image: url(../src/images/star.svg);
background-repeat: no-repeat;
object-fit: contain;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The object-fit: contain; property is not applicable to background images. It is used for replaced elements like <img>. Consider removing this line.

src/style.css
.stars--4 .stars_star:nth-child(-n + 4) {
background-image: url(../src/images/star-active.svg);
background-repeat: no-repeat;
object-fit: contain;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The object-fit: contain; property is not applicable to background images. It is used for replaced elements like <img>. Consider removing this line.

src/style.css
.stars--4 .stars_star:nth-child(n + 5) {
background-image: url(../src/images/star.svg);
background-repeat: no-repeat;
object-fit: contain;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The object-fit: contain; property is not applicable to background images. It is used for replaced elements like <img>. Consider removing this line.

src/style.css
.stars--5 .stars_star:nth-child(-n + 5) {
background-image: url(../src/images/star-active.svg);
background-repeat: no-repeat;
object-fit: contain;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The object-fit: contain; property is not applicable to background images. It is used for replaced elements like <img>. Consider removing this line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateacademy-ai-mentor mateacademy-ai-mentor mateacademy-ai-mentor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vanivnaa @mateacademy-ai-mentor