Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #2929

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Develop #2929

wants to merge 2 commits into from

Conversation

cyberte4
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code is well-structured and meets the core requirements of the task! 🎉 The minor optimization regarding the use of the spread operator in setTodos doesn't impact functionality, so it's not a blocker. Keep up the great work, and consider this optimization for future improvements! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

user: usersFromServer.find(user => user.id === userId),
};

setTodos([...todos, newTodo]);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are using the spread operator to create a new array when adding a new todo. Since setTodos is a state update function, it is not necessary to create a new array with the spread operator. You can directly pass the new array to setTodos without spreading it. This is a minor optimization according to the checklist: 'If you are using a non-mutating array method, you don't need to create a copy of the array'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants