Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #2932

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

phoenixka4
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the Todo application! 🎉 The code is well-structured and meets the task requirements. There are a couple of minor issues, such as the typo in handelSubmit and the use of 0 for userId, which could be improved for clarity. Keep up the good work and consider these suggestions for future enhancements! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

setHasSelectError(false);
};

const handelSubmit = (event: React.FormEvent) => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the function name handelSubmit. It should be handleSubmit to maintain consistency and avoid confusion.


export const App: React.FC = () => {
const [title, setTitle] = useState('');
const [userId, setUserId] = useState(0);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The userId state is initialized to 0, which is used as a placeholder in the select dropdown. Consider using null or another non-numeric value to represent the unselected state, as 0 could be mistaken for a valid user ID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants